post-android landing: ensure salgados comments on the android merge request gets addressed
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Linaro Image Tools |
Fix Released
|
High
|
Jeremy Chang |
Bug Description
From: https:/
On Mon, 2011-04-04 at 09:25 +0000, Alexander Sack wrote:
> Hi salgado,
>
> is it ok to merge the current state? we still have some changes
> pending wrt what artifacts we will really release and so. Jeremy and
> me discussed this and we think refactoring/reuse of code effort should
> be done in one batch before the 11.05 release.
I agree the refactoring to avoid code duplication can be done later, and
I said so in my review. The most important change I proposed was to use
separate config classes for android as that would be much cleaner but
more importantly would make for a better baseline on where to build
further android-related changes.
I'd be happy to postpone this provided that there was an XXX in the code
for it to be fixed later, but this really was a trivial change and I see
in the last merge proposal that most of what I asked for is already
done, so I see no reason why this shouldn't be done now. All that is
left to do is create the AndroidBoardCon
and move get_android_
that we can then get rid of the image_type argument and the ugly change
below.
- sfdisk_cmd = board_config.
- should_
+ if image_type == "ANDROID":
+ sfdisk_cmd = board_config.
+ should_
+ else:
+ sfdisk_cmd = board_config.
+ should_
Related branches
- James Westby (community): Approve
-
Diff: 503 lines (+201/-129) (has conflicts)5 files modifiedlinaro-android-media-create (+14/-19)
linaro_image_tools/media_create/__init__.py (+6/-14)
linaro_image_tools/media_create/android_boards.py (+158/-0)
linaro_image_tools/media_create/boards.py (+0/-53)
linaro_image_tools/media_create/partitions.py (+23/-43)
description: | updated |
Changed in linaro-image-tools: | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Jeremy Chang (jeremychang) |
Changed in linaro-image-tools: | |
status: | Triaged → Fix Committed |
Changed in linaro-image-tools: | |
status: | Fix Committed → Fix Released |