linaro-media-create doesn't check if --hwpack is a real file

Bug #727776 reported by Lee Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro Image Tools
Fix Released
Low
Milo Casagrande

Bug Description

For example, if you provide --hwpack ~/dirname/ l-m-c will not provide a valid "--hwpack argument needs to be a regular file".

Instead this is seen:
cp: omitting directory `hwpacks/hwpack.maverick.linaro.bsp-ux500/'
Traceback (most recent call last):
  File "/usr/bin/linaro-media-create", line 122, in <module>
    install_hwpacks(ROOTFS_DIR, TMP_DIR, args.hwpack_force_yes, *hwpacks)
  File "/usr/lib/pymodules/python2.6/linaro_media_create/hwpack.py", line 55, in install_hwpacks
    install_hwpack(chroot_dir, hwpack_file, hwpack_force_yes)
  File "/usr/lib/pymodules/python2.6/linaro_media_create/hwpack.py", line 68, in install_hwpack
    copy_file(hwpack_file, chroot_dir)
  File "/usr/lib/pymodules/python2.6/linaro_media_create/hwpack.py", line 101, in copy_file
    cmd_runner.run(['cp', filepath, directory], as_root=True).wait()
  File "/usr/lib/pymodules/python2.6/linaro_media_create/cmd_runner.py", line 65, in wait
    raise SubcommandNonZeroReturnValue(self._my_args, returncode)
linaro_media_create.cmd_runner.SubcommandNonZeroReturnValue: Sub process "['sudo', 'cp', 'hwpacks/hwpack.maverick.linaro.bsp-ux500/', '/tmp/tmpaGDA58/binary']" returned a non-zero value

Related branches

Revision history for this message
Guilherme Salgado (salgado) wrote : Re: [Bug 727776] [NEW] linaro-media-create doesn't check if --hwpack is a real file

 status triaged
 priority low

Changed in linaro-image-tools:
importance: Undecided → Low
Milo Casagrande (milo)
Changed in linaro-image-tools:
assignee: nobody → Milo Casagrande (milo)
milestone: none → 2012.05
Milo Casagrande (milo)
Changed in linaro-image-tools:
status: Triaged → In Progress
Fathi Boudra (fboudra)
Changed in linaro-image-tools:
milestone: 2012.05 → 2012.06
Milo Casagrande (milo)
Changed in linaro-image-tools:
status: In Progress → Fix Committed
Changed in linaro-image-tools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.