Move to linaro_image_tools.* modules to allow sharing code and make modules private
Bug #711310 reported by
Loïc Minier
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Linaro Image Tools |
Fix Released
|
Medium
|
Loïc Minier |
Bug Description
Hey
We don't have a place to store common code between hwpack and linaro_
I think we should move to these module names:
linaro_
linaro_
linaro_
Thanks,
Related branches
lp:~lool/linaro-image-tools/shuffle-modules
- Guilherme Salgado (community): Approve
-
Diff: 641 lines (+99/-90)30 files modified.testr.conf (+1/-1)
COPYING (+4/-4)
linaro-hwpack-create (+2/-1)
linaro-media-create (+11/-11)
linaro_image_tools/hwpack/builder.py (+3/-3)
linaro_image_tools/hwpack/hardwarepack.py (+2/-2)
linaro_image_tools/hwpack/testing.py (+6/-3)
linaro_image_tools/hwpack/tests/__init__.py (+8/-8)
linaro_image_tools/hwpack/tests/test_better_tarfile.py (+1/-1)
linaro_image_tools/hwpack/tests/test_builder.py (+6/-6)
linaro_image_tools/hwpack/tests/test_config.py (+1/-1)
linaro_image_tools/hwpack/tests/test_hardwarepack.py (+3/-3)
linaro_image_tools/hwpack/tests/test_packages.py (+2/-2)
linaro_image_tools/hwpack/tests/test_script.py (+3/-3)
linaro_image_tools/hwpack/tests/test_tarfile_matchers.py (+2/-2)
linaro_image_tools/hwpack/tests/test_testing.py (+2/-2)
linaro_image_tools/media_create/__init__.py (+1/-1)
linaro_image_tools/media_create/boards.py (+2/-2)
linaro_image_tools/media_create/check_device.py (+1/-1)
linaro_image_tools/media_create/hwpack.py (+2/-2)
linaro_image_tools/media_create/partitions.py (+1/-1)
linaro_image_tools/media_create/populate_boot.py (+1/-1)
linaro_image_tools/media_create/rootfs.py (+1/-1)
linaro_image_tools/media_create/tests/__init__.py (+1/-1)
linaro_image_tools/media_create/tests/fixtures.py (+2/-2)
linaro_image_tools/media_create/tests/test_media_create.py (+21/-18)
linaro_image_tools/media_create/unpack_binary_tarball.py (+1/-1)
linaro_image_tools/media_create/utils.py (+1/-1)
linaro_image_tools/tests/__init__.py (+4/-2)
linaro_image_tools/tests/integration.txt (+3/-3)
Changed in linaro-image-tools: | |
status: | New → Triaged |
milestone: | none → 0.5.0 |
importance: | Undecided → Medium |
summary: |
- Refactor module names + Move to linaro_image_tools.* modules to allow sharing code |
Changed in linaro-image-tools: | |
milestone: | 0.5.0 → 0.4.4 |
Changed in linaro-image-tools: | |
assignee: | nobody → Loïc Minier (lool) |
Changed in linaro-image-tools: | |
status: | Triaged → In Progress |
Changed in linaro-image-tools: | |
status: | In Progress → Fix Committed |
Changed in linaro-image-tools: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I would also like to make the modules private
14:58 < lool> salgado-physio, james_w: Thinking about python-hwpack +
python- linaro- media-create -> python- linaro- image-tools, I was
wondering whether we actually want to make these modules public,
anyway, right?
or whether we should have them private instead? The latter would
seem safer, as I don't think we're guaranteeing any API, and all
tools using these modules are in linaro-image-tools itself
15:01 < james_w> lool, we're not guaranteeing anything, but I don't see a point
in preventing people to use them at all
15:01 < james_w> lool, I'd prefer a note stating that the API is not stable
15:06 < lool> james_w: I'm not comfortable with this; first, I don't see where
we'd put the note as to have it easily discoverable; second, I
feel that as soon as third-party scripts will use the API, we
will compelled not to break them; third, the API can still be
used from the private directory