l-m-c should not install packages on host system without user consent
Bug #704029 reported by
Guilherme Salgado
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Linaro Image Tools |
Fix Released
|
Medium
|
Milo Casagrande | ||
Bug Description
Currently if one of the commands used by l-m-c is not available, we install the package providing it automatically using apt-get install. This is not nice and we should instead ask users whether or not they want us to do so.
Related branches
lp:~milo/linaro-image-tools/bug704029
- Deepti B. Kalakeri (community): Needs Fixing
- Milo Casagrande (community): Needs Fixing
- Данило Шеган: Pending requested
-
Diff: 177 lines (+77/-19)3 files modifiedlinaro_image_tools/tests/fixtures.py (+5/-4)
linaro_image_tools/tests/test_utils.py (+37/-10)
linaro_image_tools/utils.py (+35/-5)
| Changed in linaro-image-tools: | |
| importance: | Undecided → Medium |
| Changed in linaro-image-tools: | |
| status: | New → Triaged |
Revision history for this message
| Christian Reis (kiko) wrote | #1 |
Revision history for this message
| Christian Reis (kiko) wrote | #2 |
| Changed in linaro-image-tools: | |
| status: | Triaged → In Progress |
| status: | In Progress → Fix Committed |
| Changed in linaro-image-tools: | |
| status: | Fix Committed → Confirmed |
| status: | Confirmed → Triaged |
| Changed in linaro-image-tools: | |
| assignee: | nobody → Milo Casagrande (milo) |
| Changed in linaro-image-tools: | |
| status: | Triaged → In Progress |
| milestone: | none → 2012.06 |
| Changed in linaro-image-tools: | |
| status: | In Progress → Fix Committed |
| Changed in linaro-image-tools: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Here's a simple implementation that uses apt-get's -s mode to discover what packages will be installed before prompting the user for it. I'm not sure using a raw_input that far deep into the callstack is a nice thing, but it seems to be the l-m-c style <wink>
I'd like suggestions on how to test this and on the XXXs; other than that it does what's needed, I think.