TypeError: _get_bootcmd() takes exactly 2 arguments (3 given)

[Naresh Kamboju]

while building ubuntu image with media create tool with latest Sep-02 pre build images
(hwpack_linaro-vexpressdt-rtsm_20120902-264_armhf_supported.tar.gz and linaro-precise-developer-20120902-349.tar.gz) and latest linaro-image-tools
created only
 * sd.img
Not able to create following
 * img.axf
 * initrd.img-3.4-0-linaro-lt-vexpressdt-rtsm
 * vexpress-v2p-ca15-rtsm.dtb
 * vmlinuz-3.4-0-linaro-lt-vexpressdt-rtsm

$ bzr branch lp:linaro-image-tools
$ linaro-image-tools/linaro-media-create --dev fastmodel --output-directory fastmodel --image_size 2000M --hwpack hwpack_linaro-vexpressdt-rtsm_*_armhf_supported.tar.gz --binary linaro-precise-developer-*.tar.gz

Error Log:
------------------
build log is pasted here.
https://pastebin.linaro.org/852/

$ ../linaro-image-tools/linaro-media-create --dev fastmodel --output-directory fastmodel --image_size 2000M --hwpack hwpack_linaro-vexpressdt-rtsm_*_armhf_supported.tar.gz --binary linaro-precise-developer-*.tar.gz
------------------------------------------------------------
Installing (linaro-hwpack-install) hwpack_linaro-vexpressdt-rtsm_20120902-264_armhf_supported.tar.gz in target rootfs.
Unpacking hardware pack ...Done
Updating apt package lists ...
...
Writing inode tables: done
Creating journal (8192 blocks): done
Writing superblocks and filesystem accounting information: done

This filesystem will be automatically checked every 36 mounts or
180 days, whichever comes first. Use tune2fs -c or -i to override.
Will use kernel=/tmp/tmpTKLbTl/rootfs/binary/boot/filesystem.dir/boot/vmlinuz-3.4-0-linaro-lt-vexpressdt-rtsm, initrd=/tmp/tmpTKLbTl/rootfs/binary/boot/filesystem.dir/boot/initrd.img-3.4-0-linaro-lt-vexpressdt-rtsm, dtb=/tmp/tmpTKLbTl/rootfs/binary/boot/filesystem.dir/boot/dt-3.4-0-linaro-lt-vexpressdt-rtsm/vexpress-v2p-ca15-rtsm.dtb.
Traceback (most recent call last):
  File "../linaro-image-tools/linaro-media-create", line 240, in <module>
    args.is_live, args.is_lowmem, args.consoles)
  File "/mnt/ubuntu/naresh_kamboju/linaro-image-tools/linaro_image_tools/media_create/boards.py", line 806, in populate_boot
    rootfs_id, boot_disk, boot_device_or_file)
  File "/mnt/ubuntu/naresh_kamboju/linaro-image-tools/linaro_image_tools/media_create/boards.py", line 676, in make_boot_files
    i_img_data, d_img_data)
  File "/mnt/ubuntu/naresh_kamboju/linaro-image-tools/linaro_image_tools/media_create/boards.py", line 662, in _get_boot_env
    boot_env["bootcmd"] = cls._get_bootcmd(i_img_data, d_img_data)
TypeError: _get_bootcmd() takes exactly 2 arguments (3 given

Build Success:
--------------------
I have created image again with linaro-image-tools-2012.06 where it is successfully created all required files.

PASS Version:
------------------
 $ ./linaro-image-tools-2012.06/linaro-media-create --version
linaro-media-create 2012.06 : qemu-arm version 0.15.50 (Debian
0.15.50-2011.08-0ubuntu4), Copyright (c) 2003-2008 Fabrice Bellard

FAIL Version:
------------------
 $ ./linaro-image-tools/linaro-media-create --version
linaro-media-create 2012.08.1 : qemu-arm version 0.15.50 (Debian
0.15.50-2011.08-0ubuntu4), Copyright (c) 2003-2008 Fabrice Bellard

[Riku Voipio (riku-voipio)]

Fixed in the linked branch.