permission errors during submitting jobs are not clear

[Marcin Juszkiewicz]

I decided to submit job to lava (with not existing test) so I logged there, took a look and go:

20:48 hrw@puchatek:lava$ lava-tool submit-job https://validation.linaro.org/lava-server/RPC2/ lets-test-0116-job.json
EXPERIMENTAL - SUBJECT TO CHANGE (See --experimental-notice for more info)
ERROR: <Fault 401: 'Authentication required.'>

Ah, right - forgot token.

20:48 hrw@puchatek:lava$ lava-tool auth-add https://validation.linaro.org/lava-server/RPC2/
Paste token for https://<email address hidden>/lava-server/RPC2/:
Token added successfully for user hrw.

20:48 hrw@puchatek:lava$ lava-tool submit-job https://validation.linaro.org/lava-server/RPC2/ lets-test-0116-job.json
EXPERIMENTAL - SUBJECT TO CHANGE (See --experimental-notice for more info)
ERROR: <Fault 401: 'Authentication required.'>

Oops, username forgot.

20:48 hrw@puchatek:lava$ lava-tool submit-job https://<email address hidden>/lava-server/RPC2/ lets-test-0116-job.json EXPERIMENTAL - SUBJECT TO CHANGE (See --experimental-notice for more info)
ERROR: <Fault 403: 'Permission denied.'>

WTH?

Some time later Zygmunt arrived so we got a chat. He told me that under precise there can be a problem with keeping auth data (gnome keyring or kde wallet - I use second one). Checked kwallet manager and my token is stored there. Anyway workaround was to give token as password:

22:29 hrw@puchatek:lava$ lava-tool submit-job https://hrw:<email address hidden>/lava-server/RPC2/ ./lets-test-0116-job.json
EXPERIMENTAL - SUBJECT TO CHANGE (See --experimental-notice for more info)
ERROR: <Fault 403: 'Permission denied.'>

He said: "ah, you do not have bit : set. will do it now".

22:30 hrw@puchatek:lava$ lava-tool submit-job https://hrw:<email address hidden>/lava-server/RPC2/ ./lets-test-0116-job.json
EXPERIMENTAL - SUBJECT TO CHANGE (See --experimental-notice for more info)
ERROR: <Fault 400: 'Decoding JSON failed: Expecting object: line 32 column 9 (char 940).'>

Oops, fixed.

22:33 hrw@puchatek:lava$ lava-tool submit-job https://hrw:<email address hidden>/lava-server/RPC2/ ./lets-test-0116-job.json
EXPERIMENTAL - SUBJECT TO CHANGE (See --experimental-notice for more info)
submitted as job id: 9045

Yay!

But why lava-scheduler-tool (or rather lava-tool) had this problem? Why permission errors do not give any help? Would be nice to get "<Fault 401: 'Authentication required. Provide username'>" or "<Fault 403: 'Permission denied. Contact LAVA guys to set permissions for you.'>" in such moments.

Also JSON errors could be reported at any moment - would be nice.

[Michael Hudson-Doyle (mwhudson)]

I was sure there was a bug about reporting JSON errors immediately but I can't find it. Agree with the other points.

[Michael Hudson-Doyle (mwhudson)]

Well hm, one case of this is going to be a bit more difficult than I thought it was going to be :/

It turns out that we already send vaguely meaningful messages in plain text in the response body when a token is invalid for some reason. But xmlrpclib doesn't look at the response body at all when the response code is != 200 (contrary to the http rfc's suggestion, it turns out).

We can certainly give better messages when there is token but should be and when the token is for a user that does not have the magic permission bit set though.