problem with URL trigger since jenkins migration

[Fathi Boudra]

In trying to trigger my kbuilder job using the URL trigger, I noticed that this is now failing since the Jenkins upgrade. Since it's
passing a URL as an argument, all of the special characters are escaped, but Jenkins used to unpack this back into a format that could be used in commands.

For example, see the TREE parameter here:
https://ci.linaro.org/view/people/job/khilman-kbuilder/365/arch=arm,defconfig=defconfig,label=kernel_build_vps/parameters/

Jenkins used to decode this automatically, but it's not anymore, which results in the get fetch commands that use that URL failing.

[Kevin Hilman (khilman-deactivatedaccount)]

FYI... I'm working around this in the job by manually decoding the URL from the $TREE input variable.

TREE=`python -c "import urllib, sys; print urllib.unquote(sys.argv[1])" $TREE`

[Fathi Boudra (fboudra)]

I wasn't able to reproduce on my local instance, then I tried on ci.l.o by creating a new job, same result: can't reproduce.

I edited khilman-builder job, commented the work around and saved the job.
afaics, only the build #365 has been affected all the other builds up to #372 are ok.
I'll continue to monitor the next builds to see if it happens again.

[Kevin Hilman (khilman-deactivatedaccount)]

@Fathi: can you try to reproduce using my url_trigger tool[1] ? Just run "url_trigger.py" by iteslf, and it will submit a test job and you'll see the problem. Maybe I should be doing something else in my tool? I'm just using urllib.urlencode() to pass the arguments.

You don't see a lot of jobs (other than #365) that exhibit the problem because I deleted all the failed ones.

[1] https://git.linaro.org/people/kevin.hilman/build-scripts.git/blob/HEAD:/url_trigger.py

[Kevin Hilman (khilman-deactivatedaccount)]

This not only affects URLs, but any arguments passed into the URL trigger that need escaping.

For example, in the same job, some arguments can contain slashes, so they must be escaped to be passed in a URL. Jenkins used to unescape these, but no longer does.

[Chase Qi (chase-qi)]

Migrated to bugzilla: https://bugs.linaro.org/show_bug.cgi?id=508