the image url in lava-job is not correct

[Yongqin Liu]

the url of images defined in lava-job file is not right.
all panda/staging-panda/staging-panda-11.12-release are the same.

like this one:https://android-build.linaro.org/builds/~linaro-android/panda/#build=401
the images url are :
    http://android-build.linaro.org/builds/~linaro-android/panda/401/target/product/panda/boot.tar.bz2
    http://android-build.linaro.org/builds/~linaro-android/panda/401/target/product/panda/system.tar.bz2
    http://android-build.linaro.org/builds/~linaro-android/panda/401/target/product/panda/userdata.tar.bz2
but the urls defined in lava-job file are as below:
    https://android-build.linaro.org/jenkins/job/linaro-android_panda/401/artifact/build/out/target/product/full_panda/userdata.tar.bz
  https://android-build.linaro.org/jenkins/job/linaro-android_panda/401/artifact/build/out/target/product/full_panda/boot.tar.bz2
  https://android-build.linaro.org/jenkins/job/linaro-android_panda/401/artifact/build/out/target/product/full_panda/system.tar.bz2
And each of these urls returns a HTTP 404 Not Found error code.

[Frans Gifford (fgiff)]

The correct urls should be:

https://android-build.linaro.org/jenkins/job/linaro-android_panda/401/artifact/build/out/target/product/panda/userdata.tar.bz2
https://android-build.linaro.org/jenkins/job/linaro-android_panda/401/artifact/build/out/target/product/panda/system.tar.bz2
https://android-build.linaro.org/jenkins/job/linaro-android_panda/401/artifact/build/out/target/product/panda/boot.tar.bz2

i.e. .../product/panda/... and not .../product/full_panda/...

[Frans Gifford (fgiff)]

Probably related to the fact that since ICS, we use TARGET_PRODUCT=full_panda rather than the old TARGET_PRODUCT=panda

[Paul Sokolovsky (pfalcon)]

I'd also like to make processing more data-driven. I.e. avoid ladders of:

if foo == "bar":

in the code, and instead to have:

PRODUCT_MAP = {
"foo": "bar",
}

or

PRODUCT_MAP = {
"foo": ("bar", "baz"),
}

IMHO, this ticket is good chance to do such refactor. But if not, let's spawn another ticket for that.

[Frans Gifford (fgiff)]

Great suggestion, I don't like long if/elses either.

Added a PRODUCT_MAP object to map a TARGET_PRODUCT to its corresponding LAVA parameters.

[Zach Pfeffer (pfefferz)]

Thanks Frans!

On 28 November 2011 05:50, Frans Gifford <email address hidden> wrote:
> Great suggestion, I don't like long if/elses either.
>
> Added a PRODUCT_MAP object to map a TARGET_PRODUCT to its corresponding
> LAVA parameters.
>
> --
> You received this bug notification because you are a member of Linaro
> Android Team, which is subscribed to Linaro Android.
> Matching subscriptions: all-android-bugs
> https://bugs.launchpad.net/bugs/897114
>
> Title:
>  the image url in lava-job is not correct
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/linaro-android/+bug/897114/+subscriptions
>

--
Zach Pfeffer
Android Platform Team Lead, Linaro Platform Teams
Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog

[Paul Sokolovsky (pfalcon)]

No issues raised, so assuming fixed.