Need a "retest on LAVA" button on android-build

Bug #878832 reported by Zach Pfeffer
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro Android
Won't Fix
Medium
Unassigned
Linaro Android Infrastructure
Won't Fix
Medium
Unassigned
Obsolete LAVA Test
Invalid
Undecided
Unassigned

Bug Description

A recent failure: https://android-build.linaro.org/jenkins/job/linaro-android_staging-panda/49/parsed_console/? showed that android-build.l.o submitted a job to v-l-o and it failed to connect. It would be good to have a re-test button on the build page: https://android-build.linaro.org/builds/~linaro-android/staging-panda/#build=49 to handle this case (auto retest on failure could be a next step).

Zach Pfeffer (pfefferz)
Changed in linaro-android:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Frans Gifford (fgiff)
assignee: Frans Gifford (fgiff) → Yongqin Liu (liuyq0307)
Revision history for this message
Yongqin Liu (liuyq0307) wrote :

And there is another thing, it should first submit the job using, the job has not been submitted to v-l-o.
So may be it's better to provide an interface on v-l-o to submit job for this case.

Frans Gifford (fgiff)
Changed in linaro-android:
milestone: none → backlog
Frans Gifford (fgiff)
description: updated
Fathi Boudra (fboudra)
Changed in linaro-android:
milestone: backlog → none
Fathi Boudra (fboudra)
Changed in linaro-android:
assignee: Yongqin Liu (liuyq0307) → nobody
Revision history for this message
Fathi Boudra (fboudra) wrote :

Unassigned Yongqin Liu. Validation Team need to estimate the work and plan as appropriate.
AFAICS, it's changing the UI front end to re-submit a job using the LAVA interface provided by Validation Team.

Revision history for this message
Yongqin Liu (liuyq0307) wrote :

I have done some parts. see branch. lp:~liuyq0307/linaro-android-frontend/fix-878832
It's mainly related to the display on the android page. please see the attachment for reference.

Revision history for this message
Paul Larson (pwlars) wrote :

another possibility here is that it would be useful to have a "retest" button in the scheduler for any test job. What it would do, is to resubmit the exact same job json again, and return the new job number. This would not *replace* the previous job, just do it again basically. It would be simple enough to also give it a "resubmit" api that does the same thing when given the job number, and we could make use of that here. There's a blueprint in for this right now.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote : Re: [Bug 878832] Re: Need a retest on LAVA button on android-build

On Fri, 28 Oct 2011 18:01:20 -0000, Paul Larson <email address hidden> wrote:
> another possibility here is that it would be useful to have a "retest"
> button in the scheduler for any test job. What it would do, is to
> resubmit the exact same job json again, and return the new job number.
> This would not *replace* the previous job, just do it again basically.
> It would be simple enough to also give it a "resubmit" api that does the
> same thing when given the job number, and we could make use of that
> here. There's a blueprint in for this right now.

The problem with a retest button in the scheduler is that android-build
records the ID of the originally submitted job, so even if the job is
run again, the android-build build page will still show the original
results. I imagine this is not what is wanted.

However, James and I had a conversation about this a while ago and came
up with this idea: allow scheduler jobs to be referenced by job_name, at a
URL along the lines of:

    $lava-server/scheduler/+job-by-name/$JOB_NAME

The immediate objection to this idea is that $JOB_NAME is not
necessarily unique -- but we can turn that into a feature by having the
above URL return the *most recently submitted* job with that name --
which means that using a retest button in the scheduler will do the
right thing.

Given that the job name is now recorded in the database (as
'description', perhaps slightly confusingly) this should be easy enough
to implement.

Cheers,
mwh

Revision history for this message
Paul Larson (pwlars) wrote : Re: Need a retest on LAVA button on android-build

That's probably ok, as long as we are pretty sure that we wouldn't have an *unrelated* job with the same job name. That's unlikely to happen here, not sure about other cases. Does this help them pull in the results to the build page though? or just link to them?

I was thinking if they had a button they clicked to resubmit the job, it would just resubmit the original job and get back a new job id that could be used the same way as before to reference the results. This could be appended to the existing results on the build page, or replace it, which ever their preference.

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote : Re: [Bug 878832] Re: Need a retest on LAVA button on android-build

On Mon, 31 Oct 2011 13:56:58 -0000, Paul Larson <email address hidden> wrote:
> That's probably ok, as long as we are pretty sure that we wouldn't have
> an *unrelated* job with the same job name. That's unlikely to happen
> here, not sure about other cases.

Ah yes this is what happens when I write emails when super tired on
planes: I forget things.

I regard the issue of multiple jobs with the same ID to fall into the
"if you break it you get to keep both pieces" sort of thing.

> Does this help them pull in the results to the build page though? or
> just link to them?

In the implementation I had in mind it would do both. Instead of
hitting

  $scheduler/$job_id/json

to get the bundle link as it does today, the page would hit something
like:

  $scheduler/+by-job-name/$job_name/json

which would return a link to the results of the most recent job with
that name.

> I was thinking if they had a button they clicked to resubmit the job, it
> would just resubmit the original job and get back a new job id that
> could be used the same way as before to reference the results. This
> could be appended to the existing results on the build page, or replace
> it, which ever their preference.

Yeah, that could work. I guess I tend to regard the build artifacts
as immutable -- although that's not strictly speaking the case.

Cheers,
mwh

Zygmunt Krynicki (zyga)
Changed in lava-test:
status: New → Invalid
Revision history for this message
Alexander Sack (asac) wrote : Re: Need a retest on LAVA button on android-build

we need this feature to enforce LAVA success as part of our release process. Please come back with the most minimal intrusive approach you can think of so we can make it happen during the .03 cycle.

Changed in linaro-android:
assignee: nobody → Paul Sokolovsky (pfalcon)
importance: Medium → Critical
milestone: none → 12.03
assignee: Paul Sokolovsky (pfalcon) → Данило Шеган (danilo)
Zach Pfeffer (pfefferz)
Changed in linaro-android:
importance: Critical → High
importance: High → Critical
summary: - Need a retest on LAVA button on android-build
+ Need a "retest on LAVA" button on android-build
Changed in linaro-android-infrastructure:
milestone: none → 2012.03
importance: Undecided → Critical
status: New → Triaged
Zach Pfeffer (pfefferz)
Changed in linaro-android:
importance: Critical → Medium
assignee: Данило Шеган (danilo) → nobody
milestone: 12.03 → none
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

It's unclear why this gets "Critical" for Linaro Infrastructure - it doesn't represent existing feature which broke and needs urgent fix. It doesn't even represent anything which Infrastructure team can work on - it depends on LAVA features. Adjusting correspondingly.

Changed in linaro-android-infrastructure:
importance: Critical → Medium
status: Triaged → Incomplete
milestone: 2012.03 → backlog
Fathi Boudra (fboudra)
Changed in linaro-android-infrastructure:
milestone: backlog → none
Revision history for this message
Milosz Wasilewski (mwasilew) wrote :

Not needed in Android anymore.

Changed in linaro-android:
status: Confirmed → Won't Fix
Revision history for this message
Fathi Boudra (fboudra) wrote :

Superseded provided by the feature in LAVA to re-submit job (job actions).

Changed in linaro-android-infrastructure:
status: Incomplete → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers