pinned-manifest should expand relative urls

Bug #903660 reported by Frans Gifford
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro Android
Fix Released
Undecided
Unassigned
Linaro Android Build Tools
Fix Released
Undecided
Unassigned
Linaro Android Infrastructure
Fix Released
Undecided
Unassigned
linaro-android-recreate-kernel
Fix Released
Critical
Frans Gifford

Bug Description

Google decided to use relative urls in manifests for ICS (http://android.git.linaro.org/gitweb?p=platform/manifest.git;a=commit;h=9381f5c96fe3d4e4918a66ea418215c01919f4eb).

This means the pinned manifest no longer identifies the server from which many projects originated.

We should expand relative urls like ".." into absolute urls.

Frans Gifford (fgiff)
Changed in linaro-android-recreate-kernel:
status: New → Triaged
importance: Undecided → High
importance: High → Critical
milestone: none → 11.12
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

Well, a pinned manifest is produced by "repo" and we just use it as is. I yet need to look what's wrong with it (doesn't it preserve <remote>'s?)

Revision history for this message
Frans Gifford (fgiff) wrote :

It preserves the remotes, but the AOSP one is ".." which is a bit ambiguous. Having said that though, we do also preserve the job config, which tells us where the manifest came from, so we can work out that it's supposed to be $(dirname $MANIFEST_REPO)/..

Revision history for this message
Frans Gifford (fgiff) wrote :

Closing for kernel rebuild script as it can work out the remote using the jenkins config.

Feel free to mark as invalid for the other projects if you're happy that the pinned manifest requires a matching jenkins config.

Changed in linaro-android-recreate-kernel:
status: Triaged → Fix Committed
assignee: nobody → Frans Gifford (fgiff)
Frans Gifford (fgiff)
Changed in linaro-android-recreate-kernel:
status: Fix Committed → Fix Released
Changed in linaro-android:
status: New → Fix Released
Changed in linaro-android-build-tools:
status: New → Fix Released
Changed in linaro-android-infrastructure:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.