gperftools support is missing

[Marcin Juszkiewicz]

http://code.google.com/p/gperftools/ lacks AArch64 support.

When tried to cross compile it tries to use x86 assembly.

[Marcin Juszkiewicz (hrw)]

I think that atomics operations like src/base/atomics-internal-*.h need to be written for AArch64.

[Steve McIntyre (steve-mcintyre)]

Most of the asm seems to be implementing atomics for various platforms. See src/base/atomicops.h:

#if defined(__MACH__) && defined(__APPLE__)
#include "base/atomicops-internals-macosx.h"
#elif defined(__GNUC__) && defined(ARMV6)
#include "base/atomicops-internals-arm-v6plus.h"
#elif defined(ARMV3)
#include "base/atomicops-internals-arm-generic.h"
#elif defined(_WIN32)
#include "base/atomicops-internals-windows.h"
#elif defined(__GNUC__) && (defined(__i386) || defined(__x86_64__))
#include "base/atomicops-internals-x86.h"
#elif defined(__linux__) && defined(__PPC__)
#include "base/atomicops-internals-linuxppc.h"
#else
// Assume x86 for now. If you need to support a new architecture and
// don't know how to implement atomic ops, you can probably get away
// with using pthreads, since atomicops is only used by spinlock.h/cc
//#error You need to implement atomic operations for this architecture
#include "base/atomicops-internals-x86.h"
#endif

I'd *expect* this to be reasonably easy to do by just using gcc builtins, but that'll need verifying

[Anmar Oueja (anmar)]

This bug will not block Owen from using 13.01 OpenEmbedded release.

[Riku Voipio (riku-voipio)]

According to Koen, this is needed by mongodb.

[Riku Voipio (riku-voipio)]

I know have a patch that implements the gperftools atomics using gcc builtins , needs some testing, backporting to OE and submitting upstream.

[Riku Voipio (riku-voipio)]

There's more aarch64 porting needed than just atomics. For example, a code copy of:

https://code.google.com/p/linux-syscall-support/

[Ilias Biris (ibiris)]

Right are you going to look into those as well? Or should I ask mwhudson
to chip in?

thanks,

Ilias

--
Ilias Biris - <email address hidden>
Technical Program Manager, Linaro
M: [phone], IRC: ibiris, Skype: ilias_biris
Linaro.org | Open source software for ARM SoCs

On 29 January 2014 14:51, Riku Voipio <email address hidden> wrote:

> There's more aarch64 porting needed than just atomics. For example, a
> code copy of:
>
> https://code.google.com/p/linux-syscall-support/
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1091352
>
> Title:
> gperftools support is missing
>
> Status in Linaro AArch64 cross-distro work:
> In Progress
>
> Bug description:
> http://code.google.com/p/gperftools/ lacks AArch64 support.
>
> When tried to cross compile it tries to use x86 assembly.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/linaro-aarch64/+bug/1091352/+subscriptions
>

[Riku Voipio (riku-voipio)]

Patches now at:

http://git.linaro.org/people/riku.voipio/gperftools.git/shortlog/refs/heads/aarch64-port

Also submitted upstream:

https://code.google.com/p/gperftools/issues/detail?id=603

[Riku Voipio (riku-voipio)]

Commits applied upstream:

https://code.google.com/p/gperftools/source/detail?r=15b5e7a35c83ce5d38fa523f2c291a2ac30bb8ed
https://code.google.com/p/gperftools/source/detail?r=d31f522f0e1b0e87ee3d5941e331ba745a0f5c23

testing would be appreciated.