liblightdm-qt: power.cpp using incorrect interfaces and Session Bus

Bug #852803 reported by Faheem Pervez on 2011-09-17
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Light Display Manager
High
Unassigned
lightdm (Ubuntu)
High
Unassigned

Bug Description

Version: 0.9.7
Distributions used: Debian Sid (aptosid) and Ubuntu 11.10 beta 1
Arch: x86

Hi,

I've been noticing that when running lightdm-qt-greeter, the shutdown etc. options have been disabled.

Looking at liblightdm-qt's power.cpp, I've noticed that it's doing the following:
* Not explicitly specifying the use of the System Bus. When not given a forth parameter explictly stating what Bus to use, QDBusInterface uses the Session Bus by default. All the power-related daemons uses the System Bus to the best of my knowledge.
* For the ConsoleKit QDBusInterface it's specifying "org.freedesktop.ConsoleKit" as the interface when it should be "org.freedesktop.ConsoleKit.Manager"
* For the suspend and hibernate options, it's using the "org.freedesktop.PowerManagement" interface. As I'm a latecomer to Linux, I do not know much about Linux power managment daemons and the like, but Google suggests that UPower is "in" now. Accordingly, I've changed the paths and names to use UPower's, like in liblightdm-gobject. Suspending works for me in KDE with this change.

Faheem Pervez (qwerty12) wrote :
Changed in lightdm:
status: New → Triaged
importance: Undecided → High
Robert Ancell (robert-ancell) wrote :

Fixed in 0.9.8, thanks Faheem!

Changed in lightdm:
status: Triaged → Fix Committed
Changed in lightdm (Ubuntu):
status: New → Fix Committed
importance: Undecided → High

The attachment "Quick fix for the problems mentioned" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Changed in lightdm:
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lightdm - 1.0.0-0ubuntu1

---------------
lightdm (1.0.0-0ubuntu1) oneiric; urgency=low

  [ Steve Langasek ]
  * don't start on graphics-device-added; reintroducing this reverted the fix
    for bug #615549 from maverick without explanation.
  * clean up the completely illegible start rule for debian/lightdm.upstart,
    killing off the unnecessary parentheses
  * debian/lightdm.upstart: when lightdm is shut down by a runlevel call,
    emit an upstart event that can be caught by plymouth so it can
    distinguish between the DM shutting down for a runlevel change vs. other
    causes. LP: #854329.

  [ Robert Ancell ]
  * New upstream release.
    [ 0.9.8 ]
    - GetSeatForCookie and GetSessionForCookie are now deprecated. They
      remain for now but use the XDG_SEAT_PATH and XDG_SESSION_PATH
      environment variables instead.
    - Change log filenames to be unique across different display types.
    - Fix up script hooks, add regression tests for them
    - Complete removal of X code from the core of LightDM, so it can better
      support various display types
    - Add ability to set the language of a user from the greeter (LP: #803858)
    - Set LANG variable based on the user language
    - Add language selector into GTK greeter (disabled by default)
    - Allow TCP/IP connections if xserver-allow-tcp is true
    - Allow lightdm --version to be run as non-root
    - Automatically respond to PAM messages without prompts (LP: #783598)
    - Create 'AddLocalXSeat' D-Bus method, and require root to use 'AddSeat'
    - Fix multi-seat configuration picking the same display number (LP: #851362)
    - Use correct D-Bus and power interface in liblightdm-qt (LP: #852803)
    - Run pam_setcred inside the session process so pam_group works
      (LP: #851347)
    - Make sure one session is always selected in the GTK greeter (LP: #819177)
    [ 1.0.0 ]
    - Explicitly grab keyboard focus in GTK greeter
    - Fix removed power and a11y menu items in GTK greeter
    - Put system binary directory into path when running in test mode
      (LP: #860003)
    - Call pam_getenvlist after pam_setcred

  [ Lionel Le Folgoc ]
  * Make the gtk greeter easily themable by derivatives: (LP: #845549)
    - rename lightdm-gtk-greeter.conf to lightdm-gtk-greeter-ubuntu.conf,
      and handle the move in maintainer scripts.
    - manage /etc/lightdm/lightdm-gtk-greeter.conf with update-alternatives,
      by default it uses /etc/lightdm/lightdm-gtk-greeter-ubuntu.conf with a
      very low priority.
  * debian/control: lightdm-gtk-greeter provides lightdm-gtk-greeter-config.
 -- Robert Ancell <email address hidden> Wed, 28 Sep 2011 16:00:20 +1000

Changed in lightdm (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers