make gtk+ fully optional

Bug #849980 reported by Christoph Junghans on 2011-09-14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Light Display Manager

Bug Description

This patch does two things:
- adds back support for >=gtk-2.0 instead of gtk-3.0 only for distributions, which are a bit behind with gtk+
- allows to disable gtk+ greeter even if gtk+ is installed (in the case one only wants the qt4 greeter)

summary: - make gtk+ fully optinal
+ make gtk+ fully optional
Christoph Junghans (junghans) wrote :

An updated version of the patch for ligthdm-0.9.5

Changed in lightdm:
status: New → Triaged
importance: Undecided → Low
Robert Ancell (robert-ancell) wrote :

I've made a similar change to make the GTK and Qt greeters optional. I'm not going to support GTK2, it will have to be patched in distributions that don't use GTK3 yet.

Changed in lightdm:
status: Triaged → Fix Committed
Changed in lightdm:
status: Fix Committed → Fix Released
Markos Chandras (hwoarang) wrote :

Are you sure this is fixed? I can't see the patch neither in 1.0.2 nor in the hg repo

Markos Chandras (hwoarang) wrote :

You seem to have applied the patch wrong.

In this line is broken.
elif test x"enable_gtk_greeter" = "xyes"; then

you forgot to put a '$' before enable_gtk_greeter variable

Please re-open this bug since it is not fixed

Robert Ancell (robert-ancell) wrote :

Fixed in 1.0 branch and trunk. Not this only means --enable-gtk-greeter=yes is broken, i.e. no and auto still work fine.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers