lightdm-gtk-greeter segfaults in get_user_iter when adding a new user

Bug #822470 reported by Jason Conti on 2011-08-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Light Display Manager
High
Robert Ancell
lightdm (Ubuntu)
High
Unassigned

Bug Description

Steps to reproduce with lightdm-gtk-greeter 0.9.2:
1) Switch to another vt or login through ssh
2) sudo adduser someusername
3) lightdm-gtk-greeter will crash

The segfault occurs when user_changed_cb is triggered. When a new user is added, the user is appended to the end of the list, so when user_changed_cb calls get_user_iter, it will search through every row before finally finding the user at the end. However, the name for the "Other..." user is NULL, so when strcmp is called, the greeter crashes.

Related branches

Sebastien Bacher (seb128) wrote :

There is a patch on http://bazaar.launchpad.net/~jconti/lightdm/check_null_user/revision/1020

Do you think you could maybe do a merge request from it? It would show on the review queue this way, you can click on "Propose for merging" on the https://code.launchpad.net/~jconti/lightdm/check_null_user page for that

Changed in lightdm:
assignee: nobody → Robert Ancell (robert-ancell)
status: New → Confirmed
Changed in lightdm (Ubuntu):
status: New → Triaged
importance: Undecided → High
Changed in lightdm:
importance: Undecided → High
status: Confirmed → Fix Committed
Changed in lightdm (Ubuntu):
status: Triaged → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lightdm - 0.9.3-0ubuntu4

---------------
lightdm (0.9.3-0ubuntu4) oneiric; urgency=low

  * Updated to current trunk, that's a candidate version version for the next
    update, it fixes those issues:
    - login doesn't work for ecryptfs users (lp: #823775, #824594)
    - "lightdm-gtk-greeter segfaults in get_user_iter when adding a new user"
    (lp: #822470)
    - fix fallback from org.freedesktop.Accounts to passwd format (lp: #817835)
    - empty autologin-user should not be passed to pam (lp: #817581)
  * debian/control.in:
    - build-depends on quilt, it's needed with source v1
    - don't build-depends on valac, vala is not used in the current version
  * debian/lightdm.install:
    - install the manpages as well
  * debian/lightdm.manpages:
    - dropped, it's installed by the upstream make install
  * debian/rules:
    - use the quilt rule
  * debian/source/format:
    - use source v1, it works better with vcs workflows
 -- Sebastien Bacher <email address hidden> Thu, 18 Aug 2011 15:29:42 +0200

Changed in lightdm (Ubuntu):
status: Fix Committed → Fix Released
Changed in lightdm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers