empty autologin-user should not be passed to PAM

Bug #817581 reported by Guido Berhoerster on 2011-07-28
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Light Display Manager
Undecided
Unassigned
lightdm (Ubuntu)
Low
Unassigned

Bug Description

If autologin-user in lightdm.conf is set to an empty string this should not be passed on to PAM. At least with the pam_permit module from Linux PAM which is usually employed for password-less login on Linux setting the username to an empty string will result in a successful login as the "nobody" user. This is probably never desirable.
See the attached patch for a proposed fix.

Related branches

Guido Berhoerster (gber) wrote :
Sebastien Bacher (seb128) wrote :

Thank you for your work there, Robert, Michael could you review the patch? Not sure if that would solve the liveCD case but seems similar

Changed in lightdm (Ubuntu):
importance: Undecided → Low
status: New → Confirmed
Michael Terry (mterry) wrote :

Looks fine to me. I put the patch into a bzr merge proposal for Robert's review ease. Thanks Guido!

tags: added: patch
Changed in lightdm:
status: New → Fix Committed
Changed in lightdm (Ubuntu):
status: Confirmed → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lightdm - 0.9.3-0ubuntu4

---------------
lightdm (0.9.3-0ubuntu4) oneiric; urgency=low

  * Updated to current trunk, that's a candidate version version for the next
    update, it fixes those issues:
    - login doesn't work for ecryptfs users (lp: #823775, #824594)
    - "lightdm-gtk-greeter segfaults in get_user_iter when adding a new user"
    (lp: #822470)
    - fix fallback from org.freedesktop.Accounts to passwd format (lp: #817835)
    - empty autologin-user should not be passed to pam (lp: #817581)
  * debian/control.in:
    - build-depends on quilt, it's needed with source v1
    - don't build-depends on valac, vala is not used in the current version
  * debian/lightdm.install:
    - install the manpages as well
  * debian/lightdm.manpages:
    - dropped, it's installed by the upstream make install
  * debian/rules:
    - use the quilt rule
  * debian/source/format:
    - use source v1, it works better with vcs workflows
 -- Sebastien Bacher <email address hidden> Thu, 18 Aug 2011 15:29:42 +0200

Changed in lightdm (Ubuntu):
status: Fix Committed → Fix Released
Changed in lightdm:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers