No password needed to Log in after cancel the password and then reset again
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Light Display Manager |
Invalid
|
Undecided
|
Unassigned | ||
OEM Priority Project |
Fix Released
|
Low
|
Unassigned | ||
Trusty |
Fix Released
|
Low
|
Unassigned | ||
Xenial |
Fix Released
|
Low
|
Unassigned | ||
unity-control-center (Ubuntu) |
Fix Released
|
High
|
Iain Lane | ||
Xenial |
Fix Released
|
High
|
Iain Lane | ||
Yakkety |
Fix Released
|
High
|
Iain Lane |
Bug Description
[ Description ]
If you use unity-control-
[ Test case ]
1. Open the dash, type "User Accounts", open the user accounts panel of unity-control-
2. Make sure the current user (which must be an admin) is selected in the list of user's on the left hand side.
3. Click "Unlock" at the top right, and enter the user's password.
4. Click the dots to the right of "Password", to open the dialog where you can change the password mode.
5. In the combo box at the top, select "Log in without a password". Save the dialog.
6. Open a terminal, and execute `grep nopasswdlogin /etc/group'. Note that the current user is present.
7. Re-open the password dialog as in step 4.
8. Select "Set a password now", and set a password. Save the dialog.
9. Open a terminal, and execute `grep nopasswdlogin /etc/group'.
At step 9, if the bug is present then the user will still be in the group. If it is fixed then the user will not.
[ Fix ]
unity-control-
The proposed fix (in the attached MP) is to always make this call when setting a password, even in this passwd case.
[ QA ]
Run the test case above. Additionally,
- Try to use the dialog to change passwords without unlocking it.
- Try to change both the current and another user's password.
Make sure the nopasswdlogin membership is right at all times and the new password always gets applied (e.g. try logging out and in to check the settings).
[ Regression potential ]
The fix changes a couple of things
- We now call act_user_
- We now call act_user_
AFAIK both of these changes are fine, but we should run the QA tests above to get confidence that they didn't break password setting.
[ Original description ]
1. Go to path "System Setting --> User Accounts--> Unlock" to unlock system setting.
2. Click "Password --> Action --> Log in without password -->Change to clear Log in password. (as doing so, the user is added to group "nopasswdlogin")
3. Check that the user is in the nopasswdlogin group
4. Then do the similar action "Set a password now" as the same way to set Log in password.
5. Check that the user is *not* in the nopasswdlogin group.
The key problem is: it won't remove user from nopasswdlogin in step 4. At step 5, you are left in the group.
Related branches
- Robert Ancell: Approve
- Sebastien Bacher: Approve
-
Diff: 17 lines (+2/-2)1 file modifiedpanels/user-accounts/um-password-dialog.c (+2/-2)
- Robert Ancell: Approve
-
Diff: 17 lines (+2/-2)1 file modifiedpanels/user-accounts/um-password-dialog.c (+2/-2)
- Robert Ancell: Approve
-
Diff: 30 lines (+3/-3)2 files modifieddebian/control (+1/-1)
panels/user-accounts/um-password-dialog.c (+2/-2)
no longer affects: | oem-priority/precise |
Changed in oem-priority: | |
importance: | Undecided → High |
importance: | High → Critical |
Changed in lightdm (Ubuntu): | |
status: | Incomplete → Confirmed |
Changed in oem-priority: | |
status: | New → Confirmed |
description: | updated |
Changed in lightdm (Ubuntu): | |
importance: | Undecided → High |
Changed in lightdm (Ubuntu): | |
assignee: | nobody → Robert Ancell (robert-ancell) |
tags: | added: n+1 |
tags: | added: trusty |
description: | updated |
affects: | unity-control-center → unity-control-center (Ubuntu) |
description: | updated |
description: | updated |
description: | updated |
Changed in unity-control-center (Ubuntu): | |
assignee: | nobody → Iain Lane (laney) |
status: | New → Triaged |
importance: | Undecided → High |
description: | updated |
Changed in oem-priority: | |
status: | Confirmed → In Progress |
Changed in unity-control-center (Ubuntu Xenial): | |
assignee: | nobody → Iain Lane (laney) |
status: | Confirmed → In Progress |
Changed in unity-control-center (Ubuntu Yakkety): | |
assignee: | nobody → Iain Lane (laney) |
status: | Confirmed → In Progress |
no longer affects: | lightdm (Ubuntu) |
no longer affects: | lightdm (Ubuntu Xenial) |
no longer affects: | lightdm (Ubuntu Yakkety) |
Changed in lightdm: | |
status: | New → Invalid |
tags: | added: desktop |
Changed in oem-priority: | |
importance: | Critical → High |
Changed in oem-priority: | |
status: | In Progress → Triaged |
importance: | High → Medium |
tags: |
added: verification-done-xenial removed: verification-done |
Changed in oem-priority: | |
importance: | Medium → Low |
Changed in oem-priority: | |
status: | Triaged → Fix Released |
What version of lightdm are you using?
Is this happening in Yakkety?