Webkit greeter lacks an User Pic support.
Bug #939819 reported by
Andrea Virgillito
This bug affects 10 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
LightDM GTK Greeter |
Fix Released
|
Wishlist
|
Unassigned | ||
LightDM Webkit Greeter |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Why don't we put an user pic nearby the account selection area? I think it's a good idea to focus better the selected user, together with the wallpaper transition effect.
summary: |
- Webkit greeter lacks an User Pic and an Access Button for the listed - users. + Webkit greeter lacks an User Pic support and an Access Button for the + listed users. |
summary: |
- Webkit greeter lacks an User Pic support and an Access Button for the - listed users. + Webkit greeter lacks an User Pic support. |
description: | updated |
Changed in lightdm-gtk-greeter: | |
importance: | Undecided → Wishlist |
Changed in lightdm-gtk-greeter: | |
status: | New → Fix Committed |
milestone: | none → 1.5.1 |
Changed in lightdm-webkit-greeter: | |
status: | New → Fix Released |
To post a comment you must log in.
Not sure if this is the place to report this but I'm currently developing a lightdm webkit theme and have problems with user pics.
In the original theme, user pic is displayed but there is a bug if the user has no pic (i.e. no ~/.face file) : rather than displaying the stock person icon, it displays the webkit missing file icon.
This comes from the fact that the code checks if user.image.length is > 0, assuming that if the file exists, length will be > 0 and it will be = 0 if the file doesn't exists. Well, that's wrong: user.image is a string ("/home/ username/ .face") which is sent back by LightDM (or the LightDM WebKit engine specifically? I have no experience with other greeters or LightDM in general) even if the file doesn't exist. So the theme always thinks a ~/.face file exists, even if it's not the case.
Either this is a bug in the LightDM webkit engine (maybe it should send back an empty string for user.image if ~/.face or ~/.face.icon doesn't exists?) or it's not and in that case the existence of the file has to be tested through JavaScript (which is not an easy task, although it might be possible with the new File API of HTML 5).