Search button does nothing

Bug #1922377 reported by Lorenzo Miniero
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Lifeograph
Fix Released
Undecided
Unassigned

Bug Description

Hi,

I was using lifeograph 1.6 before, and noticed the search button wasn't working anymore. As such, I compiled 2.0.0 to see if it was a known issue that had been fixed already, but that didn't help either: clicking the "search" button still does nothing.

I do remember it working some time ago: I remember noticing it worked differently from how the search worked in 1.5 (I actually preferred how it worked in 1.5 more, but that's a different matter), but it did work. At some point it must have stopped working but I'm not sure when, as I didn't use the search feature every day: it may have been after a recent fix I reported a few months ago, that turned out to be a GTK problem on Fedora (unfortunately I can't find the bug report though?), as that's the last time I remember building lifeograph.

It doesn't seem to be an issue limited to search only as I initially thought, though: if I click other icons in the same group (e.g., calendar, filter, and more in general the ones from the "three dots" icon), nothing happens either. It looks like the whole widget that should appear below the content is missing entirely, which might explain why none of those buttons work (IIRC they just changed the content of that).

Not sure if it's an issue in lifeograph, or something broken in GTK again: if it helps, Fedora 34 comes with GTK 3.24.27.

Revision history for this message
Lorenzo Miniero (lminiero) wrote :

Apologies, the issue at the time was in Gtkmm, not GTK:
https://bugs.launchpad.net/lifeograph/+bug/1902268

The version available on Fedora is 3.24.4.

Revision history for this message
Lorenzo Miniero (lminiero) wrote :

PS: apologies for the typo, I'm on Fedora 33, not 34.

Revision history for this message
Lorenzo Miniero (lminiero) wrote :

Just in case this helps, this is a screenshot of lifeograph opening the example diary. As you can see in the picture, there's no widget placeholder at the bottom, which is where I assume the extra features (including search) end up being rendered (also looking at the screenshots on the website).

Revision history for this message
Ahmet Öztürk (dmxe) wrote :

Hi Lorenzo,

I believe that you have just shrunk the bottom panel down to zero. Can you drag the bottom edge of the text editor up so that becomes visible again?

But please be careful as you need to find the sweet spot for resizing the bottom panel rather than the whole window. At that point the cursor is different than in window resize mode.

If that did not work please open the config file ~/.config/lifeograph/lifeo.conf while Lifeograph is not working.

In it find the line starting with p (small p not capital P) and replace the number after it with half of its value.

Start Lifeograph and bottom panel should work again.

Revision history for this message
Lorenzo Miniero (lminiero) wrote :

Oh that was it, and I feel really stupid now... :-D

In my defense, it was invisible so I had no idea it was there: maybe the code should enforce a minimum height it cannot go beyond when you shrink it? Thanks for the quick response, please feel free to close this issue! (I don't see an option to do it myself)

Revision history for this message
Ahmet Öztürk (dmxe) wrote :

That is OK. The feedback was useful anyway. Others may fall for this as well.

I have just committed a change to master that resizes the bottom panel to half of the total height if it is less than 10% of the total height when the search button or any other bottom panel button is clicked. It will be part of v2.0.1.

Changed in lifeograph:
status: New → Fix Committed
Ahmet Öztürk (dmxe)
Changed in lifeograph:
milestone: none → 2.0.1
Ahmet Öztürk (dmxe)
Changed in lifeograph:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.