MOD2 breaks list functionality

[Vesal Vojdani]

I while ago I complained that the lists didn't work and then suddenly worked. Well, it has now happened again, and it turns out there is some weirdness with Ubuntu on my laptop that means Gdk::MOD2 is always set. This is supposed to be numlock, but turning numlock on and off does not change it. I found a similar problem reported against Zim, so it's not just my system:

https://bugs.launchpad.net/zim/+bug/507372

They ended up just ignoring irrelevant mod-keys. Changing line 1764 of widget_textview.cpp to ignore Gdk::MOD2_MASK will make it work on my system, except the toolbar doesn't work, so maybe something similar is going on when I press the toolbar buttons, but I don't know.

[Ahmet Öztürk (dmxe)]

So, the issue is about MOD2 being set for no obvious reason? OK. I have modified the code to ignore any masks but alt, ctrl, and shift like suggested in Zim bug you mentioned. Can you pull revision 1312 ant try it, please?

As to the toolbar, it should not be affected by MOD2. Did it stop working after your modification on line 1764 or at the same time as typing MOD2 problem emerged?

[Vesal Vojdani (vesal)]

The text entry now works perfectly. I searched your revisions and the button works in r1251, but not since r1252. So judging by the commit comment, the toolbar button now toggles bullets. That actually works. I expected it to also insert a bullet when the line is empty, which it used to do before, but now it does nothing. Personally, I don't care about that since I would always insert using the keyboard (and that now works). The toggle functionality is very nice indeed, so I'm not sure if this is a problem or not... still maybe you don't want to surprise the user, so if possible, maybe you can make it insert a bullet if the line is empty, and otherwise do the toggle magic? As far as I'm concerned though, this bug is fixed with r1251.

[Vesal Vojdani (vesal)]

Sorry, I meant fixed with r1312. (Strange, can't I edit my previous comments here?)

[Ahmet Öztürk (dmxe)]

On my computer it also works for empty lines, except for the first line which is reserved for entry title. I will investigate what may cause yours to fail.