libusermetrics

When two data sources share the same ID, bad things happen

Bug #1243104 reported by Pete Woods
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libusermetrics
Fix Released
High
Pete Woods
libusermetrics (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Since the addition of per-application namespaces in response to the security review, two sources can share the same ID.

Unfortunately, libusermetricsoutput was not updated to handle this, and so the data sets associated with sources sharing the same ID fight each other.

Related branches

lp:~unity-team/libusermetrics/handle-shared-data-source-ids
PS Jenkins bot (community): Approve (continuous-integration)
Unity Team: Pending requested
Diff: 721 lines (+120/-124)
17 files modified
data/com.canonical.UserMetrics.xml (+0/-2)
data/com.canonical.usermetrics.DataSet.xml (+1/-1)
data/com.canonical.usermetrics.UserData.xml (+2/-2)
po/en_GB.po (+15/-15)
po/libusermetrics.pot (+15/-15)
src/libusermetricsoutput/SyncedUserData.cpp (+15/-13)
src/libusermetricsoutput/SyncedUserData.h (+3/-2)
src/libusermetricsoutput/SyncedUserMetricsStore.cpp (+20/-32)
src/libusermetricsoutput/SyncedUserMetricsStore.h (+2/-2)
src/libusermetricsoutput/UserMetricsImpl.cpp (+9/-9)
src/libusermetricsoutput/UserMetricsStore.cpp (+2/-2)
src/libusermetricsoutput/UserMetricsStore.h (+1/-1)
src/usermetricsservice/DBusDataSet.cpp (+2/-2)
src/usermetricsservice/DBusDataSet.h (+3/-2)
src/usermetricsservice/DBusUserData.cpp (+8/-3)
src/usermetricsservice/DBusUserMetrics.cpp (+2/-3)
tests/unit/libusermetricsoutput/TestSyncedUserMetricsStore.cpp (+20/-18)
Pete Woods (pete-woods)
Changed in libusermetrics:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Pete Woods (pete-woods)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:libusermetrics at revision 143, scheduled for release in libusermetrics, milestone Unknown

Changed in libusermetrics:
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libusermetrics - 1.1.1+14.04.20131125-0ubuntu1

---------------
libusermetrics (1.1.1+14.04.20131125-0ubuntu1) trusty; urgency=low

  [ Pete Woods ]
  * Data sources are now keyed by their dbus path in
    libusermetricsoutput This allows them to share the same IDs. (LP:
    #1243104)
  * Append the libusermetrics/themes path to each XDG entry

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 144
 -- Ubuntu daily release <email address hidden> Mon, 25 Nov 2013 03:56:50 +0000

Changed in libusermetrics (Ubuntu):
status: New → Fix Released
Pete Woods (pete-woods)
Changed in libusermetrics:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.