sources shows time rather than count in messaging menu when count set to 0

[Alex Launi]

In my messaging menu, when a folder is empty the count shows as time since last mail received rather than 0 unread messages

[Alex Launi (alexlauni)]

Very simple test case demonstrating the problem

[Lars Karlitski (larsu)]

The attached branch fixes one half of the problem: setting the count to zero will not show a time anymore. Instead, nothing will be shown, because a source with a 0 count should not appear in the messaging menu in the first place.

Adding webapps-applications. The gmail webapp should not add a source with a 0 count.

[Robert Carr (robertcarr)]

I think it sets a bad precedent to require this logic in the userscript as we can't count on the web to be well behaved. Furthermore each additional guideline we have to place on userscript authors adds an additional pain.

I think it should be filtered in the context daemon (IndicatorView).

Filtering it in the context daemon as opposed to the API has a small benefit. Namely imagine the following state.

GMail, interest 1: ShowIndicator(count -> 3)
(time passes)
GMail, interest 2: ShowIndicator(count -> 0)

The indicator should be filtered from the view.

[Alex Launi (alexlauni)]

I think we need feedback from design here. There's no detail in the spec that actually specified whether or not the source should show. There could be a difference between a 0 count, and no count, and that's a distinction that should be defined in the spec.

[Matthew Paul Thomas (mpt)]

Agreed with both Lars and Robert. Specification updated: "If a source has neither a non-zero count *nor* a time, it should not be shown at all." <https://wiki.ubuntu.com/MessagingMenu?action=diff&rev2=90&rev1=89> Thanks, Alex.

[Launchpad Janitor (janitor)]

This bug was fixed in the package indicator-messages - 12.10.6daily12.11.21.1-0ubuntu1

---------------
indicator-messages (12.10.6daily12.11.21.1-0ubuntu1) raring; urgency=low

  [ Mathieu Trudel-Lapierre ]
  * debian/rules:
    - Use autogen.sh for dh_autoreconf.
    - Drop the override for dh_makeshlibs.
    - Add DPKG_GENSYMBOLS_CHECK_LEVEL=4.
  * debian/control:
    - Fix styling: add trailing commas at the end of lists.
    - Update Vcs-Bzr, Vcs-Browser fields and add a notice for developers.
    - Add libgtest-dev to Build-Depends.
  * Automatic snapshot from revision 329 (bootstrap):
    - Clear the detail (count or time) of a source when another type of detail
      is set. (LP: #1071640)

  [ Automatic PS uploader ]
  * Automatic snapshot from revision 331
 -- Automatic PS uploader <email address hidden> Wed, 21 Nov 2012 10:41:37 +0000