space in name field causes failure of media player interface to export

[Alex Launi]

Unity.init({ name: "My Webapp", ...});
works and will create a launcher icon/context/etc however if it fails when using the MediaPlayer API. The interface gets created on the context daemon bus, but the needed mpris bus does not get exported. This behaviour is NOT exhibited if that is modified to Unity.init({ name: "MyWebapp", ...});

[Conor Curran (cjcurran)]

Looking over the libunity code at the moment, the entry point is

public MusicPlayer (string desktop)
Which internally this desktop string is used create a new DesktopAppInfo

http://www.valadoc.org/#!api=gio-unix-2.0/GLib.DesktopAppInfo.DesktopAppInfo

Going on the spec passing in names of apps won't work, we need the name of the desktop file.

[Alex Launi (alexlauni)]

Conor, the unity music player IS given the desktop file name

unity-webapps-music-player-context.c
87 UnityMusicPlayer *player;
92 player = unity_music_player_new (context->desktop_name);

and then when exporting the bus you do ->
// TODO: I think you will need to ensure the name is only one word and lower case
var mpris_extension = consumer.app_info.get_name().down();
var dbus_name = MPRIS_INTERFACE_PREFIX.concat (mpris_extension);
      bus_name_owner_handle =
            Bus.own_name (BusType.SESSION,
                          dbus_name,
                          BusNameOwnerFlags.NONE,
                          null,
                          () => { Trace.log ("Owning name %s", dbus_name); },
                          on_name_lost);

but never convert spaces to underscores or anything.

[Conor Curran (cjcurran)]

ah sorry, sounds like a fix then !