Not enough flexibility in vhost place-holders

Bug #1781164 reported by Mathieu Alorent on 2018-07-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Libravatar
Undecided
Unassigned

Bug Description

The place-holders used in files `cdn.apache2.conf` and `seccdn.apache2.conf` should be different.

I mean, the `<VirtualHost __VHOSTADDRESS__>` have to be different in both files, as one will listen on port 80 and the other on port 443.

I propose to have them statically defined as `<VirtualHost *:80>` `<VirtualHost *:443>`

Related branches

François Marier (fmarier) wrote :

While it's not obvious from the shortname that is shown there, these placeholders are actually different.

They each get substituted by the postinst script of their respective libravatar-cdn or libravatar-seccdn packages:

  https://git.launchpad.net/~libravatar/libravatar/tree/debian/libravatar-cdn.postinst#n48
  https://git.launchpad.net/~libravatar/libravatar/tree/debian/libravatar-seccdn.postinst#n48

and the variables are defined here:

  https://git.launchpad.net/~libravatar/libravatar/tree/debian/libravatar-cdn.templates
  https://git.launchpad.net/~libravatar/libravatar/tree/debian/libravatar-seccdn.templates

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers