Automatic photo-email assignment on photo upload doesn't work
Bug #1041720 reported by
François Marier
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Libravatar (obsolete) |
Fix Released
|
Medium
|
François Marier |
Bug Description
Steps to reproduce:
1- pick an email that's not used by any account
2- login using Persona (which will auto-create an account)
3- upload a photo
At this stage, the photo looks like it's associated with that email address. In fact, it is in the database.
However, on disk, the photo isn't associated to the email hash.
Changed in libravatar: | |
importance: | High → Medium |
Changed in libravatar: | |
status: | In Progress → Fix Committed |
Changed in libravatar: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think that this is due to a race condition:
1- photo is uploaded but isn't optimized yet
2- photo is assigned to the email
3- we attempt to create a hardlink from the photo in user/ to the email hash in avatar/
4- the photo is optimized and moved to user/ after the hardlink creation failed
So one easy fix for this would be to switch to symlink.
This would also have the advantage of reducing the amount of data rsynced to the mirrors and would make it easy to fix bug #769764.