Name clash with module m_interp
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| libPSML |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
LibPSML 1.1.5 exports its module m_interp as-is, which causes a name clash with Abinit's internal m_interp module and prevents PSML support to be marked as officially supported by Abinit. A solution has been found on the side of Abinit but it will not prevent the problem to happen again with other codes.
A recommended good practice for libraries is to use a systematic prefix for all exported Fortran modules. The attached patch implements this recommendation for m_interp, renaming it to m_psml_interp.
Since there are already a few codes depending on LibPSML, I don't expect the patch to be propagated quickly. This is why the upcoming versions of the Abinit Fallbacks will provide a patched version of LibPSML 1.1.5. It will give you time to do things peacefully and cleanly.
| Yann Pouillon (pouillon) wrote | #1 |
| Changed in libpsml: | |
| status: | New → Fix Committed |
| Changed in libpsml: | |
| status: | Fix Committed → Fix Released |
