libnotify reports spam detected by internal TB junk filter

[jmrk]

At least in my case this is quite annoying since I'm filtering ~300 spam mails a day with the TB junk filer. There should be an option to enable/disable junk reports.

[Ruben Verweij (ruben-verweij)]

Thanks for your bug report and help in making this addon better. I am working on this and I will post back when I have any results worth mentioning.

[Ruben Verweij (ruben-verweij)]

I committed a (possible) fix. Could you please test it? The code is in the branch linked to this report. If you need any help with testing, please let me know.

[jmrk (joergen-kornfeld)]

Tested it... might be some improvement. I started a bit debugging and it seems to be that junkScore is empty even when the mail is classified as spam, but i also had once a junk score of 100 (with no notification). Sorry that I cannot help further, my JS skills are pretty limited.. For testing I changed the code to:

  OnItemAdded: function OnItemAdded(aParentItem, aItem)
  {
    var header = aItem.QueryInterface(Components.interfaces.nsIMsgDBHdr);
    var junkScore = header.getStringProperty("junkscore");
    var isJunk = ((junkScore != "") && (junkScore != "0"));
----------------------
  var prompts = Components.classes["@mozilla.org/embedcomp/prompt-service;1"]
                        .getService(Components.interfaces.nsIPromptService);
     prompts.alert(null, "junkScore", junkScore);
----------------------
    if(!isJunk){
     var folder = header.folder;

     if (!this.checkFolder(folder)) {
       return;
     }

thx for any help and merry christmas!

[Ruben Verweij (ruben-verweij)]

Strange... I will have to investigate this a little bit further then. Thanks for your help and a merry christmas to you too! ;-)

[Burkart Lingner (burkart)]

On my system spam was also displayed the same way as regular new messages so I wrote a patch. It removes the event handler binding for OnItemAdded() whose junk checking didn't work for me. Instead I added a new event handler msgsClassified() which is called after messages have passed the junk filter. This function then calls the old OnItemAdded() to make the change as minimal as possible. The patch is relative to the current version 1.1 (not trunk).

To try out the patch, replace thunderbird-indicator.jar under ~/.<email address hidden>/chrome/ with the version attached to this post.