libmms handling of many URLS is broken

Bug #238984 reported by Michal Ratajsky
94
This bug affects 9 people
Affects Status Importance Assigned to Milestone
libmms
Fix Released
Undecided
Unassigned
libmms (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

libmms doesn't handle urls very well:

* Sends full path to server - this is invalid (eg sends mms://___foo__.com/path/to/media/file.mms. It should send just '/path/to/media/file.mms'

* Crashes if no path is present, like 'mms://__foo__.com/, for this it should send '/' I think

* Doesn't handle URLS that have no path but query like : mms://server.com/?test=10

Revision history for this message
Michal Ratajsky (michal429) wrote :
Revision history for this message
spiff (spiff) wrote :

just wanted to that this bug is biting in xbmc media center as well. nasty little bugger it is

summary: - Crash when using certain URLs
+ libmms handling of many URLS is broken
description: updated
Revision history for this message
Maxim Levitsky (maximlevitsky) wrote :

Just tested, and above patch works just fine

description: updated
Changed in libmms:
status: New → Confirmed
Changed in libmms (Ubuntu):
status: New → Confirmed
Revision history for this message
Maxim Levitsky (maximlevitsky) wrote :

In fact above patch is far from being perfect, it actually doesn't work for many cases.
I also noticed that there is code duplication beteween mmsh and normal mms, and this patch fixes mms only.

Here is reworked patch

Changes:

* I append to begging of path the '/', otherwise many servers won't work - windows does same too
* don't put 0 at the end, string is guaranteed to have at least one char, besides this was wrong, it would overwrite last char.
* put this in separate function and call from both mms and mmsh

Revision history for this message
Maxim Levitsky (maximlevitsky) wrote :

I hope this work won't get lost

Revision history for this message
Maxim Levitsky (maximlevitsky) wrote :

New 0.5 release incorporates this patch.
Should work now.

Changed in libmms:
status: Confirmed → Fix Released
Revision history for this message
Alessio Treglia (quadrispro) wrote :

Fixed since Maverick.

Changed in libmms (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.