Do not use -Wall unconditionally

Bug #1241633 reported by Dagobert Michelsen on 2013-10-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libmetalink
Low
Tatsuhiro Tsujikawa

Bug Description

-Wall is added unconditionally to AM_CFLAGS in lib/Makefile.am:
  AM_CFLAGS = -Wall
and to AM_CPPFLAGS in doc/examples/Makefile.am:
  AM_CPPFLAGS = -Wall -I$(top_srcdir)/lib/includes -I$(top_builddir)/lib/includes

This is bad as some compilers != GCC to not understand -Wall and adding the flag should either be tested or skipped at all.
As -Wall is also added when maintainer_mode is turned on in configure.ac it should generally not be necessary to add -Wall.

Revision history for this message
Tatsuhiro Tsujikawa (t-tujikawa) wrote :

Sorry, for long long delay. Now fix committed via r156.

Changed in libmetalink:
assignee: nobody → Tatsuhiro Tsujikawa (t-tujikawa)
importance: Undecided → Low
milestone: none → libmetalink-0.1.3
status: New → Fix Committed
Changed in libmetalink:
milestone: libmetalink-0.1.3 → none
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers