Note that they take a memcached_instance_st * as an argument.
So I am thinking that you want us to now use memcached_instance_st * in place of memcached_server_instance_st?
I would still contend that it would be nice to maintain the typedef for backward compatibility, at least until there is a major version bump. Changing the API during a patch level version bump is surprising and makes it difficult for folks that build software that uses libmemcached. For example, it looks like pylibmc will have to have this bit of #ifdef ugliness:
Here are the declarations for memcached_ server_ name and memcached_ server_ port from http:// bazaar. launchpad. net/~tangent- trunk/libmemcac hed/1.0/ view/head: /libmemcached- 1.0/server. h#L103 (these declarations also appear in libmemcached- 1.0.17) :
```C server_ name(const memcached_ instance_ st * self);
LIBMEMCACHED_API
const char *memcached_
LIBMEMCACHED_API server_ port(const memcached_ instance_ st * self);
in_port_t memcached_
```
Note that they take a memcached_ instance_ st * as an argument.
So I am thinking that you want us to now use memcached_ instance_ st * in place of memcached_ server_ instance_ st?
I would still contend that it would be nice to maintain the typedef for backward compatibility, at least until there is a major version bump. Changing the API during a patch level version bump is surprising and makes it difficult for folks that build software that uses libmemcached. For example, it looks like pylibmc will have to have this bit of #ifdef ugliness:
```C AddServerCallba ck(memcached_ st *mc, VERSION_ HEX >= 0x01000017
memcached _instance_ st instance, VERSION_ HEX >= 0x00039000
memcached _server_ instance_ st instance,
memcached _server_ st *server,
void *user) {
static memcached_return
_PylibMC_
#if LIBMEMCACHED_
#elif LIBMEMCACHED_
#else
#endif
...
}
```