memcached_string_take_value() takes wrong branch

[Arjan van Leeuwen]

In libmemcached/string.cc, in function memcached_string_take_value(), the code says

// If we fail at adding the null, we copy and move on
  if (memcached_success(memcached_string_append_null(self)))
  {
    return memcached_string_c_copy(self);
  }

The code and the comment do not agree with each other. It looks like that should have been memcached_failed. The attached patch fixes this.

Additionally, there is an assert there that I don't understand:

  if (memcached_string_length(self))
  {
    assert_msg(self, "Invalid memcached_string_st");
  }

I don't see why a non-zero length means invalid string, and the rest of the function seems to agree that it is indeed a valid string. Probably a mistake as well, but not changed in the patch since I'm not sure what was meant here.

[Brian Aker (brianaker)]

The assert_msg(self, "Invalid memcached_string_st"); <-- this is a typo

Thanks,... I will see about updating this to a more recent version.