memcached_string_take_value() takes wrong branch
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libmemcached |
Fix Committed
|
Medium
|
Brian Aker |
Bug Description
In libmemcached/
// If we fail at adding the null, we copy and move on
if (memcached_
{
return memcached_
}
The code and the comment do not agree with each other. It looks like that should have been memcached_failed. The attached patch fixes this.
Additionally, there is an assert there that I don't understand:
if (memcached_
{
assert_
}
I don't see why a non-zero length means invalid string, and the rest of the function seems to agree that it is indeed a valid string. Probably a mistake as well, but not changed in the patch since I'm not sure what was meant here.
Changed in libmemcached: | |
status: | In Progress → Fix Committed |
The assert_msg(self, "Invalid memcached_ string_ st"); <-- this is a typo
Thanks,... I will see about updating this to a more recent version.