memcached_server_by_key is broken

[Massive Media]

When upgrading from an older version (1.0.5) of libmemcached to 1.0.13, I notices that memcached_server_by_key returns invalid servers instead of just working as it should.

(I attached a test script)

The returned memcached_server_st *server is corrupt:
server->hostname is always empty and server->port is 65535

[Brian Aker (brianaker)]

memcached_server_by_key() returns a memcached_server_instance_st(), not a memcached_server_st().

The structures were similar enough such that at some point in history you could use one for the other, but this was not supported.

If you are rewriting the code I would look at using memcached(). It is much more flexible.

[Brian Aker (brianaker)]

Adding a test case with corrected code.

[Massive Media (493pocbrcycmdw7yksonho9o2qzz-o18bz-d18ecat4t1b76tkfi3vttrkfngli)]

The reason I filed this as a bug is because php-memcached supports it and has a function to retrieve the server for a given key. How should we do this?

Best,
Nicolas