grip-test no longer responds to input

[Stephen M. Webb]

[Impact]

 * The library was not supplying and gestures to client callers because of underlying change in the underlying gesture recognizer conflicting with an incorrect assumption in the libgrip library design. The assumption was that touch input device IDs were persistent across gesture recognizer instances, which has never been guaranteed to be true.

 * This bug renders the entire libgrip functionally useless, a fairly serious regression.

 * The bug fix moves to the latest version of the GEIS interface so obviates dependency on incorrect behaviour in the previous implementation.

[Test Case]

 * Using a touchscreen, invoke the eog photo viewer program and attempt to zoom a photo using the pinch gesture. Without this patch, there will be no response, with the patch the photo should zoom. See also #1120149.

[Regression Potential]

 * A programming error in the library could result in crashes in the eog or evince applications.

[Stephen M. Webb (bregma)]

The geisview tool gives unexpected errors when run with debug output enabled. See attached file.

[Stephen M. Webb (bregma)]

Running the grip-test tool with debug logging enabled shows a lack of expected device matches: both devices recognized as present should match a "Pinch,touch-2" gesture.

[Stephen M. Webb (bregma)]

Looks like the problem is that libgrip is assuming all GEIS instances return the same device ID for the same device. It's an invalid assumption. Device IDs are only valid within an instance.

[Stephen M. Webb (bregma)]

Problem in comment #1 appears to be unrelated: reported as bug #1169249.

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:libgrip at revision 77, scheduled for release in libgrip, milestone 0.3.6

[PS Jenkins bot (ps-jenkins)]

Fix committed into lp:libgrip/raring at revision 76, scheduled for release in libgrip, milestone raring-sru-0

[Launchpad Janitor (janitor)]

This bug was fixed in the package libgrip - 0.3.6daily13.06.05-0ubuntu1

---------------
libgrip (0.3.6daily13.06.05-0ubuntu1) saucy; urgency=low

  [ Stephen M. Webb ]
  * bumping to version 0.3.6

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 81

libgrip (0.3.6daily13.05.29ubuntu.unity.next-0ubuntu1) raring; urgency=low

  [ Stephen M. Webb ]
  * bumping to version 0.3.6

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 80 (ubuntu-unity/next)

libgrip (0.3.6daily13.05.17ubuntu.unity.next-0ubuntu1) raring; urgency=low

  * Automatic snapshot from revision 78 (ubuntu-unity/next)

libgrip (0.3.6daily13.05.13-0ubuntu1) raring; urgency=low

  [ Stephen M. Webb ]
  * installs grip-test to debian/tmp (LP: #1082214)
  * grip-test no longer responds to input (LP: #1168370)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 77
 -- Ubuntu daily release <email address hidden> Wed, 05 Jun 2013 02:02:11 +0000

[Adam Conrad (adconrad)]

Hello Stephen, or anyone else affected,

Accepted libgrip into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/libgrip/0.3.6daily13.06.19~13.04-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Dimitri John Ledkov (xnox)]

0.3.6daily13.06.10-0ubuntu1 <- saucy
0.3.6daily13.06.19~13.04-0ubuntu1 <- raring-proposed

The version string used for an SRU is higher than the released version in saucy, which doesn't seem right.

[Sebastien Bacher (seb128)]

That update makes eog segfault on start when run without argument, marking the bug as verification-failed ... can we get it rejected from the proposed serie? The same bug was in saucy and fixed recently, that fix should probably be backported to the raring serie as well

[Adam Conrad (adconrad)]

Removing packages from raring-proposed:
 libgrip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring
  gir1.2-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring amd64
  gir1.2-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring armhf
  gir1.2-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring i386
  gir1.2-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring powerpc
  libgrip-dev 0.3.6daily13.06.19~13.04-0ubuntu1 in raring amd64
  libgrip-dev 0.3.6daily13.06.19~13.04-0ubuntu1 in raring armhf
  libgrip-dev 0.3.6daily13.06.19~13.04-0ubuntu1 in raring i386
  libgrip-dev 0.3.6daily13.06.19~13.04-0ubuntu1 in raring powerpc
  libgrip0 0.3.6daily13.06.19~13.04-0ubuntu1 in raring amd64
  libgrip0 0.3.6daily13.06.19~13.04-0ubuntu1 in raring armhf
  libgrip0 0.3.6daily13.06.19~13.04-0ubuntu1 in raring i386
  libgrip0 0.3.6daily13.06.19~13.04-0ubuntu1 in raring powerpc
  python-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring amd64
  python-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring armhf
  python-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring i386
  python-grip 0.3.6daily13.06.19~13.04-0ubuntu1 in raring powerpc
Comment: Failed SRU verification
Remove [y|N]? y
1 package successfully removed.