Preprocessing options use non-standard naming conventions
Bug #1714252 reported by
Yann Pouillon
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libGridXC |
New
|
High
|
Yann Pouillon |
Bug Description
The preprocessing options used in LibGridXC follow non-standard naming conventions that may lead to name clashes in some cases, while some uses may be improper and/or obsolete.
The options in version 0.7.3 are the following: DEBUG_XC, GRID_SP, LIBXC, MPI, OLD_CRAY, __TEST_
This can be solved by:
- renaming LIBXC to HAVE_LIBXC;
- renaming MPI to HAVE_MPI;
- possibly getting rid of the OLD_CRAY option;
- refactor the __TEST_
Part of this issue will be fixed at the same time as bug #1714246.
To post a comment you must log in.
A few words to clarify the proposed refactoring.
The undocumented __TEST_ _MODULE_ _ALLOC_ _ CPP option is associated to the optional compilation of a test program located in the src/alloc.F90 source file. This practice is strongly discouraged, because:
- it hides tests which may be of importance deeply into the source code;
- it allows parts of the source to be kept unmaintained for long periods of times.
The recommended practice is instead to provide the test program in a separate file and control its compilation from a Makefile, in addition to briefly documenting its purpose.