FP identify is not working with broadcom sensor on Jammy

[prafulla chandra kota]

Broadcom Jammy package is provided to canonical team (Andy), attached the log file shows FP identify operation says that verification is successful, but Login screen will NOT be unlocked.

[Marco Trevisan (Treviño) (3v1n0)]

Mh, I don't see traces of failures there.

I can't debug it easily without hw, but maybe is it hanging?
Can you provide a gdb backtrace for all the threads?

[prafulla chandra kota (prafullakota)]

Hi Marco,

Andy mentioned that he is having a Broadcom CV enabled laptop, it would be
good for you to have one laptop for testing purposes.
Yes, as you mentioned, the log didn't have any errors and I was not sure
why the login screen was unlocked.

Thanks,
Prafulla

On Mon, Jul 18, 2022 at 8:41 PM Marco Trevisan (Treviño) <
<email address hidden>> wrote:

> Mh, I don't see traces of failures there.
>
> I can't debug it easily without hw, but maybe is it hanging?
> Can you provide a gdb backtrace for all the threads?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1981974
>
> Title:
> FP identify is not working with broadcom sensor on Jammy
>
> Status in libfprint-2-tod1-broadcom:
> New
>
> Bug description:
> Broadcom Jammy package is provided to canonical team (Andy), attached
> the log file shows FP identify operation says that verification is
> successful, but Login screen will NOT be unlocked.
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/libfprint-2-tod1-broadcom/+bug/1981974/+subscriptions
>
>

--
Thanks,
Prafulla Kota
9866544810

[Andy Chi (andch)]

Looks like the hardware I get is not so stable, the pid switches..after reboot. I'll find another dut to test it.

[prafulla chandra kota (prafullakota)]

Hi Andy,

It is very much stable, if you want to verify on existing hardware, you can
install 20.04 OS and load the previous BRCM driver, works fine.

PID changing from 5840/41/43 is expected as per Hardware configuration, no
issue about this, after FW upgrade, it will settle to 5843.

Thanks,
Prafulla

On Wed, Jul 20, 2022 at 2:56 PM Andy Chi <email address hidden> wrote:

> ** Attachment added: "lsusb-brcm2.txt"
>
> https://bugs.launchpad.net/libfprint-2-tod1-broadcom/+bug/1981974/+attachment/5604292/+files/lsusb-brcm2.txt
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1981974
>
> Title:
> FP identify is not working with broadcom sensor on Jammy
>
> Status in libfprint-2-tod1-broadcom:
> New
>
> Bug description:
> Broadcom Jammy package is provided to canonical team (Andy), attached
> the log file shows FP identify operation says that verification is
> successful, but Login screen will NOT be unlocked.
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/libfprint-2-tod1-broadcom/+bug/1981974/+subscriptions
>
>

--
Thanks,
Prafulla Kota
9866544810

[Loic Yhuel (lyhuel)]

This might be https://bugs.launchpad.net/libfprint-2-tod1-broadcom/+bug/1956885.

You can try to enroll a second finger, if it works fine it would confirm the issue (the fprintd update between Focal and Jammy having switched from "identify" to "verify" when there is only one finger in the verify list, and the closed source library "verify" implementation being incorrectly synchronous).

[Andy Chi (andch)]

[libfprint]
1:1.94.3+tod1-0ubuntu2~22.04.01

[fprintd]
七 21 16:05:06 ubuntu-Precision-7770 fprintd[2028]: Verify was successful!
 七 21 16:05:06 ubuntu-Precision-7770 fprintd[2028]: Device reported verify result
 七 21 16:05:06 ubuntu-Precision-7770 fprintd[2028]: report_verify_status: result verify-match
 七 21 16:05:06 ubuntu-Precision-7770 fprintd[2028]: Device reported verify completion
 七 21 16:05:06 ubuntu-Precision-7770 fprintd[2028]: Completing action 5 in idle!
 七 21 16:05:06 ubuntu-Precision-7770 fprintd[2028]: Updated temperature model after 6.99 seconds, ratio 0.35 -> 0.38, active 0 -> 0, FP_TEMPERATURE_WARM -> FP_TEMPERATURE_WARM
 七 21 16:05:06 ubuntu-Precision-7770 fprintd[2028]: verify_cb: result verify-match
 七 21 16:05:18 ubuntu-Precision-7770 fprintd[2028]: Device reported close completion
 七 21 16:05:18 ubuntu-Precision-7770 fprintd[2028]: Completing action 3 in idle!

It seems like I don't see verify-completion, so I guess that's why it does not login automatically. I also got timeout after login into system:
Impossible to get devices: Timeout was reached

@3v1n0,
Is it the same log you see?

[Andy Chi (andch)]

Enrolled second finger on DUT and I can login without problem. @prafullakota, can you help to check on your side?

[prafulla chandra kota (prafullakota)]

Hi Andy,

I verified with 2 fingers and observed that both Fingers Identity is
working fine, let me know if i need to provide any other info, it is not
working with single FP identify template on 22.04.
Does anything need to be changed from tod driver to support this feature on
22.04?

fprintd-verify is returning an error even with 2 fingers enrolled, but the
Login screen is successful with 2 finger enrollment.

if you can help to change my email for bug communication, can you add my
official email id: "<email address hidden>" to this list, as i was
suggested to use this e-mail for communication, i did change e-mail at my
profile, but this issue was created before it got changed.

fprintd-verify application log posted below: fprintd claiming FP verify is
failed, but login screen FP identify is working good.

(fprintd:3334): libfprint-device-DEBUG: 16:26:41.665: Completing action
FPI_DEVICE_ACTION_PROBE in idle!
(fprintd:3334): libfprint-device-DEBUG: 16:26:41.665: Updated temperature
model after 0.21 seconds, ratio 0.27 -> 0.27, active 0 -> 0,
FP_TEMPERATURE_COLD -> FP_TEMPERATURE_COLD
(fprintd:3334): fprintd-DEBUG: 16:26:41.668: Device Broadcom Sensors scan
type changed to 'press'
(fprintd:3334): fprintd-DEBUG: 16:26:41.668: Device Broadcom Sensors enroll
stages changed to 11
(fprintd:3334): fprintd-DEBUG: 16:26:41.668: Finger present 0
(fprintd:3334): fprintd-DEBUG: 16:26:41.668: Finger needed 0
(fprintd:3334): fprintd-DEBUG: 16:26:41.669: entering main loop
(fprintd:3334): fprintd-DEBUG: 16:26:41.669: D-Bus service launched with
name: net.reactivated.Fprint
(fprintd:3334): fprintd-DEBUG: 16:26:55.513: Requesting authorization from
:1.148 to call method 'Claim' for device 'Broadcom Sensors'
(fprintd:3334): fprintd-DEBUG: 16:26:55.514: Getting authorization to
perform Polkit action net.reactivated.fprint.device.verify
(fprintd:3334): fprintd-DEBUG: 16:26:55.521: Authorization granted to
:1.148 to call method 'Claim' for device 'Broadcom Sensors'!
(fprintd:3334): fprintd-DEBUG: 16:26:55.521: user 'adminuser' claiming the
device: 0
(fprintd:3334): libfprint-device-DEBUG: 16:26:55.636: Device reported open
completion
(fprintd:3334): libfprint-device-DEBUG: 16:26:55.637: Completing action
FPI_DEVICE_ACTION_OPEN in idle!
(fprintd:3334): libfprint-device-DEBUG: 16:26:55.637: Updated temperature
model after 13.97 seconds, ratio 0.27 -> 0.26, active 0 -> 0,
FP_TEMPERATURE_COLD -> FP_TEMPERATURE_COLD
(fprintd:3334): fprintd-DEBUG: 16:26:55.637: claimed device 0
(fprintd:3334): fprintd-DEBUG: 16:26:55.639: Requesting authorization from
:1.148 to call method 'ListEnrolledFingers' for device 'Broadcom Sensors'
(fprintd:3334): fprintd-DEBUG: 16:26:55.640: Getting authorization to
perform Polkit action net.reactivated.fprint.device.verify
(fprintd:3334): fprintd-DEBUG: 16:26:55.646: Authorization granted to
:1.148 to call method 'ListEnrolledFingers' for device 'Broadcom Sensors'!
(fprintd:3334): fprintd-DEBUG: 16:26:55.646: file_storage_discover_prints()
for user 'adminuser' in '/var/lib/fprint/adminuser/broadcom/0'
(fprintd:3334): fprintd-DEBUG: 16:26:55.646:
file_storage_print_data_load(): loaded
'/var/lib/fprint/adminuser/broadcom/0/a' Success
...

[Andy Chi (andch)]

it turns out that this bug is duplicate with Bug #1956885.
Let's track there.