iffy handling 2-03-YYY
Bug #893640 reported by
cpb
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
libECBUFR |
Fix Committed
|
Low
|
vanh souvanlasy |
Bug Description
Code in question is bufr_dataset.
case TYPE_CHNG_
ival = bufr_value_
if (isdebug)
{
}
if (ival < 0)
{
ival = bufr_negative_
ival is uint64_t, which makes the "if (ival < 0)" test a NOP. Not entirely sure what was intended here so I added a FIXME comment and left it alone.
Changed in libecbufr: | |
assignee: | nobody → vanh souvanlasy (vanh-souvanlasy) |
importance: | Undecided → Low |
Changed in libecbufr: | |
status: | New → In Progress |
milestone: | none → 0.8.4 |
status: | In Progress → Fix Committed |
To post a comment you must log in.
The return value could be negative and for this case, the returned value is not just -1 for missing
the ival should be int32_t and then the converted final value should be cast to uint64_t for output.