Bugs in donut.c

Bug #888253 reported by Bert Timmerman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libDXF
Fix Committed
Medium
Bert Timmerman

Bug Description

Line 108 : vertices_follow undeclared.
Lines 124-126 : variables undeclared.
Line 130 : dangling " */ "

reported by mtarek (https://github.com/mtarek)

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

mtarek commented:

A couple more notes :
Lines 124-126 seem to be causing a "too many parameters" error too.
Line 95 : dxf_entity_name undeclared.

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

bert commented:

Hi, thanks for the report. I will look into this shortly.
Kind regards, Bert Timmerman.

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

mtarek commented:

Quite welcome.

I'd send a small patch but I'm away from my other computer right now, so I'll just share it here :

at the beginning of the function :
char * dxf_entity_name = "DONUT"

removed the check starting at line 108 completely since it's done in the polyline function.

removed lines 124-126 and the " */ " at line 130.

Hope that helps. I haven't tested the function though, I was just trying to get it to compile.

Revision history for this message
Bert Timmerman (bert-timmerman) wrote :

bert commented:

Hi,
It's actually a "POLYLINE" entity (convenience function resulting in a donut).
Removed the undeclared variables.
Please check if this works for you too.
Kind regards, Bert Timmerman.

Changed in libdxf:
importance: Undecided → Medium
status: New → In Progress
Changed in libdxf:
milestone: none → 0.0.2
Changed in libdxf:
milestone: 0.0.2 → 0.0.1
Changed in libdxf:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.