libappindicator fails to build from latest bzr 2017-10-23

[Dave]

Libappindicator fails to build from source branched from bzr repo on 23rd Oct 2017. I don't use Ubuntu, but when I went to report a bug on the bzr repo site it brought me here.

I'm using Slackware 14.2 x86_64, gcc 5.3.0, glib 2.46.2.

Using:

./autogen.sh
CFLAGS="$SLKCFLAGS" \
CXXFLAGS="$SLKCFLAGS" \
./configure \
  --prefix=/usr \
  --libdir=/usr/lib${LIBDIRSUFFIX} \
  --sysconfdir=/etc \
  --localstatedir=/var \
  --mandir=/usr/man \
  --infodir=/usr/info \
  --with-gtk=3 \
  --docdir=/usr/doc/$PRGNAM-$VERSION \
  --build=$ARCH-slackware-linux

make

Results:

app-indicator.c: In function ‘shorty_activated_cb’:
app-indicator.c:2563:2: error: implicit declaration of function ‘indicator_desktop_shortcuts_nick_e
xec_with_context’ [-Werror=implicit-function-declaration]
  indicator_desktop_shortcuts_nick_exec_with_context(priv->shorties, nick, NULL);
  ^
cc1: all warnings being treated as errors
Makefile:769: recipe for target 'libappindicator3_la-app-indicator.lo' failed
make[2]: *** [libappindicator3_la-app-indicator.lo] Error 1
make[2]: Leaving directory '/tmp/daw/libappindicator-12.10.1/src'
Makefile:482: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/tmp/daw/libappindicator-12.10.1'
Makefile:413: recipe for target 'all' failed
make: *** [all] Error 2

Thanks.

[Dave (dave-unrealize)]

Ok. I managed to fix that by getting rid of -Werror, but now I have a new error:

app-indicator.c:58: Warning: AppIndicator3: "@id" parameter unexpected at this location:
 * @id: The ID of the indicator. Maps to AppIndicator:id.
    ^
app-indicator.c:545: Error: AppIndicator3: multiple "@arg1" parameters for identifier "AppIndicator::new-label":
         * @arg1: The string for the guide
     ^
app-indicator.h:243: Warning: AppIndicator3: "@parent" parameter unexpected at this location:
 * @parent: Parent object.
    ^
./.libs/libappindicator3.so: undefined reference to `indicator_desktop_shortcuts_nick_exec_with_context'
collect2: error: ld returned 1 exit status

linking of temporary binary failed: Command '['/bin/sh', '../libtool', '--mode=link', '--tag=CC', '--silent', 'gcc', '-o', '/tmp/daw/libappindicator-12.10.1/src/tmp-introspectkBa7Ma/AppIndicator3-0.1', '-export-dynamic', '-O2', '-fPIC', 'tmp-introspectkBa7Ma/tmp/daw/libappindicator-12.10.1/src/tmp-introspectkBa7Ma/AppIndicator3-0.1.o', '-L.', 'libappindicator3.la', '-lgio-2.0', '-lgobject-2.0', '-Wl,--export-dynamic', '-lgmodule-2.0', '-pthread', '-lglib-2.0']' returned non-zero exit status 1
/usr/share/gobject-introspection-1.0/Makefile.introspection:155: recipe for target 'AppIndicator3-0.1.gir' failed

[Sebastien Bacher (seb128)]

not a bug on the Ubuntu package, reassigning to the upstream component instead

[Dave (dave-unrealize)]

Fixed by commenting out that

indicator_desktop_shortcuts_nick_exec_with_context

line.