crossing.h:121: possible bad > expression ?

[dcb]

I just ran the static analysis tool "cppcheck" over the
source code of inkscape-0.48.4. It said many things,
including

[2geom/crossing.h:121] -> [2geom/crossing.h:121]: (style) Same expression on both sides of '>'.

Source code is

            return (ix == a.a ? a.ta : a.tb) >
                   (ix == a.a ? a.ta : a.tb);

Suggest code rework.

[Krzysztof Kosinski (tweenk)]

This is fixed in r2423. These classes will eventually be removed since they are badly written and not very useful.

[Qantas94Heavy (qantas94heavy)]

Committed to Inkscape here: https://gitlab.com/inkscape/inkscape/commit/0a2477feea6e1df586b926b8482afbf79e2355e1

Fix released with Inkscape 0.92.0.

Closed by: https://gitlab.com/Qantas94Heavy