run_nodes plugins doesn't work

Bug #323175 reported by Vicent
2
Affects Status Importance Assigned to Milestone
leo-editor
Fix Released
Wishlist
Edward K. Ream

Bug Description

Hi,

the run_nodes plugins doesn't work:

- with qt it does nothing
- with tk sometimes does nothing, sometimes raises errors, like

Exception in thread Thread-6:
Traceback (most recent call last):
  File "/usr/lib/python2.5/threading.py", line 486, in
__bootstrap_inner
    self.run()
  File "/usr/local/src/leo-editor/leo/plugins/run_nodes.py", line 244,
in run
    s=self.File.readline()
IOError: [Errno 9] Bad file descriptor

Traceback (most recent call last):

  File "/usr/local/src/leo-editor/leo/core/leoGlobals.py", line 2904,
in doHook
    return f(tag,keywords)

  File "/usr/local/src/leo-editor/leo/core/leoPlugins.py", line 295,
in doPlugins
    return doHandlersForTag(tag,keywords)

  File "/usr/local/src/leo-editor/leo/core/leoPlugins.py", line 270,
in doHandlersForTag
    val = callTagHandler(bunch,tag,keywords)

  File "/usr/local/src/leo-editor/leo/core/leoPlugins.py", line 249,
in callTagHandler
    result = handler(tag,keywords)

  File "/usr/local/src/leo-editor/leo/plugins/run_nodes.py", line 211,
in OnIdle
    OpenProcess(fn)

  File "/usr/local/src/leo-editor/leo/plugins/run_nodes.py", line 377,
in OpenProcess
    RunNode.c.selectVnode(RunNode)

  File "/usr/local/src/leo-editor/leo/core/leoNodes.py", line 1066, in
__getattr__
    raise AttributeError(attr)

AttributeError: c

This bug was first notified to the leo-editor group (thread with subject "Problem with the run_nodes plugin").

Vicent

Revision history for this message
Mark Edgington (edgimar) wrote :

I can confirm this problem on rev. 1466. If you sidestep this error by commenting out the code which marks the node, there is still another problem with the stdin/out/err file descriptor. I looked at it for a bit and tried replacing the popen3 call with subprocess.Popen, with no command output for interactive programs (e.g. "python") (non-interactive programs like "ps" work fine). Perhaps using the Popen.communicate() method would work?

Changed in leo-editor:
status: New → Confirmed
Changed in leo-editor:
importance: Undecided → Medium
Changed in leo-editor:
importance: Medium → Wishlist
Revision history for this message
Edward K. Ream (edreamleo) wrote :

This looks like a real bug, not a wishlist. I'll either fix the plugin or remove it.

Changed in leo-editor:
milestone: none → 4.10-b1
assignee: nobody → Edward K. Ream (edreamleo)
importance: Wishlist → Low
Revision history for this message
Edward K. Ream (edreamleo) wrote :

Rev 5129 fixes some crashers, but this plugin must be considered broken (experimental).

Furthermore, it's not clear how useful this plugin actually is, given that the functionality could be created fairly easily using @button nodes.

At present, EKR has no plans to work on the plugin.

Changed in leo-editor:
importance: Low → Wishlist
milestone: 4.10-b1 → none
Changed in leo-editor:
status: Confirmed → Fix Released
Revision history for this message
Edward K. Ream (edreamleo) wrote :

This has been moved to the experimental section. No further work is planned.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.