ErModeller/canvas.js - isn't following code standards

Bug #1164542 reported by Roland Chelwing
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
LenaSYS
Fix Committed
Undecided
Elof Bigestans

Bug Description

Naming isn't explanatory for the variable/function:
Example:
  // Mouse Down Result
  var downRes;

Also naming isn't following the camelBack standard:
Example:
function mouseover(x, y)

Should be:
function mouseOver(x, y)

Missing comments:
Example(line 400):
  /*
   *
   */
  function importdata()

Comments aren't following code standards:
Example:
  // List of objects
  // List of identifiers
  // List of selected object identifiers
  // The context object
  var Objects = new Array();
  var Selected = new Array();
  var Identifiers = new Array();
  var ContextObj;

Should be:
  // List of objects
  var Objects = new Array();
  // List of identifiers
  var Identifiers = new Array();
  // List of selected object identifiers
  var Selected = new Array();
  // The context object
  var ContextObj;

Code also starts with two indents.

Related branches

description: updated
Changed in lenasys:
status: New → Confirmed
summary: ErModeller/canvas.js - naming of variables isn't explanatory for
- function
+ function or following camelBack
description: updated
description: updated
summary: - ErModeller/canvas.js - naming of variables isn't explanatory for
- function or following camelBack
+ ErModeller/canvas.js - isn't following code standards
description: updated
description: updated
Changed in lenasys:
assignee: nobody → Elof Bigestans (elof-bigestans)
status: Confirmed → In Progress
Changed in lenasys:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.