submit crashes

[Aaron Bentley]

$ lbox submit -v
2012/12/06 11:53:50 Authenticating in Launchpad...
2012/12/06 11:53:50 Looking up information for branch: .
2012/12/06 11:53:50 Looking up information for branch: .
2012/12/06 11:53:50 Checking if 'bzr status' is clean for /home/abentley/canonical/charmworld
2012/12/06 11:53:50 Loading data for branch bzr+ssh://bazaar.launchpad.net/~abentley/charmworld/dev-ingest/...
2012/12/06 11:53:51 Looking for merge proposal...
2012/12/06 11:53:52 Merge proposal lp:~abentley/charmworld/dev-ingest => lp:charmworld found: https://code.launchpad.net/~abentley/charmworld/dev-ingest/+merge/138500
2012/12/06 11:53:52 Branches: lp:~abentley/charmworld/dev-ingest => lp:charmworld
2012/12/06 11:53:52 Proposal: https://code.launchpad.net/~abentley/charmworld/dev-ingest/+merge/138500
2012/12/06 11:53:52 Opening editor for change summary and description...
2012/12/06 11:54:05 -----
Add dev-ingest script

Add a script to make it easy for developers to run "ingest". It ensures the
correct python interpreter is used, and permits any location for the working
treee (as long as the parent directory is writable).
-----
2012/12/06 11:54:05 Fetching remote branch: lp:charmworld
2012/12/06 11:54:05 RIETVELD Loaded cached authentication details.
2012/12/06 11:54:05 RIETVELD Loaded cached authentication details.
2012/12/06 11:54:05 RIETVELD Requesting details for issue 6885047...
2012/12/06 11:54:05 RIETVELD Requesting commenting details for issue 6885047...
2012/12/06 11:54:06 Loading preferred email for "Aaron Bentley"...
2012/12/06 11:54:06 Rietveld: https://codereview.appspot.com/6885047
2012/12/06 11:54:11 Diffing branches for codereview: /home/abentley/canonical/charmworld => /home/abentley/canonical/lbox-715543171/lbox
2012/12/06 11:54:15 RIETVELD Requesting details for issue 6885047...
2012/12/06 11:54:15 RIETVELD Requesting commenting details for issue 6885047...
2012/12/06 11:54:15 Pushing new patch set to codereview issue 6885047...
2012/12/06 11:54:15 RIETVELD Uploading delta to issue 6885047...
2012/12/06 11:54:16 RIETVELD Response from server: Issue updated. URL: https://codereview.appspot.com/6885047
2012/12/06 11:54:16 RIETVELD Base for [revision details] already on server.
2012/12/06 11:54:16 RIETVELD Base for scripts/dev-ingest already on server.
2012/12/06 11:54:16 Merging branch /home/abentley/canonical/charmworld onto /home/abentley/canonical/lbox-715543171/lbox
2012/12/06 11:54:23 Branch merged successfully.
2012/12/06 11:54:23 No check script at /home/abentley/canonical/lbox-715543171/lbox/.lbox.check
2012/12/06 11:54:23 Committing branch: /home/abentley/canonical/lbox-715543171/lbox
2012/12/06 11:54:31 error: Failed to run "bzr commit": exit status 4
-----
Committing to: bzr+ssh://bazaar.launchpad.net/+branch/charmworld/
added scripts/dev-ingest
bzr: ERROR: bzrlib.errors.NoSuchRevision: RemoteRepository(bzr+ssh://bazaar.launchpad.net/%2Bbranch/charmworld/.bzr/) has no revision <email address hidden>

Traceback (most recent call last):
  File "/home/abentley/hacking/bzr/bzrlib/commands.py", line 930, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/commands.py", line 1121, in run_bzr
    ret = run(*run_argv)
  File "/home/abentley/hacking/bzr/bzrlib/commands.py", line 673, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/abentley/hacking/bzr/bzrlib/commands.py", line 697, in run
    return self._operation.run_simple(*args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/cleanup.py", line 136, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/cleanup.py", line 166, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/builtins.py", line 3687, in run
    lossy=lossy)
  File "/home/abentley/hacking/bzr/bzrlib/decorators.py", line 218, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/workingtree_4.py", line 218, in commit
    result = WorkingTree.commit(self, message, revprops, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/decorators.py", line 218, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/mutabletree.py", line 211, in commit
    *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/commit.py", line 290, in commit
    lossy=lossy)
  File "/home/abentley/hacking/bzr/bzrlib/cleanup.py", line 132, in run
    self.cleanups, self.func, self, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/cleanup.py", line 166, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/commit.py", line 447, in _commit
    self.rev_id = self.builder.commit(self.message)
  File "/home/abentley/hacking/bzr/bzrlib/vf_repository.py", line 204, in commit
    testament = Testament(rev, self.revision_tree())
  File "/home/abentley/hacking/bzr/bzrlib/vf_repository.py", line 230, in revision_tree
    self._new_revision_id)
  File "/home/abentley/hacking/bzr/bzrlib/decorators.py", line 155, in read_locked
    result = unbound(self, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/remote.py", line 1923, in get_inventory
    return list(self.iter_inventories([revision_id]))[0]
  File "/home/abentley/hacking/bzr/bzrlib/remote.py", line 1987, in iter_inventories
    raise errors.NoSuchRevision(self, revid)
NoSuchRevision: RemoteRepository(bzr+ssh://bazaar.launchpad.net/%2Bbranch/charmworld/.bzr/) has no revision <email address hidden>

bzr 2.6.0dev3 on python 2.7.3 (Linux-3.5.0-19-generic-x86_64-with-
    Ubuntu-12.10-quantal)
arguments: ['/home/abentley/bin/bzr', 'commit', '-F', '/tmp/commit-503793158',
    '--author', 'Aaron Bentley <email address hidden>',
    '/home/abentley/canonical/lbox-715543171/lbox']
plugins: arch[unknown], bash_completion[2.6.0dev3], builder[0.7.4dev],
    bzrtools[2.5.0], changelog_merge[2.6.0dev3], colo[0.3.1dev],
    difftacular[unknown], faultline[unknown], grep[0.5.0dev], gtk[0.104.0dev],
    hide[unknown], launchpad[2.6.0dev3], loggerhead[1.18.1],
    lpreview_body[unknown], netrc_credential_store[2.6.0dev3],
    news_merge[2.6.0dev3], openlookup[unknown], pipeline[1.4.0],
    po_merge[2.6.0dev3], pqm[1.4.0dev], trigger_scan[unknown],
    weave_fmt[2.6.0dev3]
encoding: 'utf-8', fsenc: 'UTF-8', lang: 'en_CA.UTF-8'

*** Bazaar has encountered an internal error. This probably indicates a
    bug in Bazaar. You can help us fix it by filing a bug report at
        https://bugs.launchpad.net/bzr/+filebug
    including this traceback and a description of the problem.
-----
2012/12/06 11:54:31 Removing temporary directory: /home/abentley/canonical/lbox-715543171
2012/12/06 11:54:31 That's all folks.

[Aaron Bentley (abentley)]

This may well be because I'm using bzr's native colocation, which is a relatively new feature.

[Aaron Bentley (abentley)]

Actually, it appears to be because I have checkout aliased to "checkout --lightweight". lbox is exposing a bzr bug, but this is because lbox isn't invoking checkout with --no-aliases like it really should.

[Curtis Hovey (sinzui)]

I also experience this problem, but I am using common located branches with trees (no checkouts, no co-lo). I have removed all my aliases and disabled the by bzr plugins.

[Gustavo Niemeyer (niemeyer)]

The error being reported is by bzr itself:

2012/12/06 11:54:31 error: Failed to run "bzr commit": exit status 4
-----
Committing to: bzr+ssh://bazaar.launchpad.net/+branch/charmworld/
added scripts/dev-ingest
bzr: ERROR: bzrlib.errors.NoSuchRevision: RemoteRepository(bzr+ssh://bazaar.launchpad.net/%2Bbranch/charmworld/.bzr/) has no revision <email address hidden>

lbox doesn't do anything special on the branches, with all interactions being done via the bzr command line itself. If bzr is exploding with a NoSuchRevision error on a remote branch, someone that knows better about bzr will have to look at it.

[Aaron Bentley (abentley)]

It appears that there is a bug in Bazaar that doing commits to remote branches with gpg signing enabled breaks. See below.

That bug was probably not noticed until now because doing lightweight checkouts of remote branches is not performant and therefore discouraged. It is easy to work around by using heavyweight checkouts or normal branches or stacked branches instead of lightweight checkouts.

$ bzr init lp:~abentley/+junk/gpg-commit
Created a standalone branch (format: unnamed)
$ bzr checkout --lightweight lp:~abentley/+junk/gpg-commit
$ bzr commit -m "test" gpg-commit --unchanged
Committing to: bzr+ssh://bazaar.launchpad.net/~abentley/+junk/gpg-commit/
bzr: ERROR: bzrlib.errors.NoSuchRevision: RemoteRepository(bzr+ssh://bazaar.launchpad.net/~abentley/%2Bjunk/gpg-commit/.bzr/) has no revision <email address hidden>

Traceback (most recent call last):
  File "/home/abentley/hacking/bzr/bzrlib/commands.py", line 930, in exception_to_return_code
    return the_callable(*args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/commands.py", line 1121, in run_bzr
    ret = run(*run_argv)
  File "/home/abentley/hacking/bzr/bzrlib/commands.py", line 673, in run_argv_aliases
    return self.run(**all_cmd_args)
  File "/home/abentley/hacking/bzr/bzrlib/commands.py", line 697, in run
    return self._operation.run_simple(*args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/cleanup.py", line 136, in run_simple
    self.cleanups, self.func, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/cleanup.py", line 166, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/builtins.py", line 3687, in run
    lossy=lossy)
  File "/home/abentley/hacking/bzr/bzrlib/decorators.py", line 218, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/workingtree_4.py", line 218, in commit
    result = WorkingTree.commit(self, message, revprops, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/decorators.py", line 218, in write_locked
    result = unbound(self, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/mutabletree.py", line 211, in commit
    *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/commit.py", line 290, in commit
    lossy=lossy)
  File "/home/abentley/hacking/bzr/bzrlib/cleanup.py", line 132, in run
    self.cleanups, self.func, self, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/cleanup.py", line 166, in _do_with_cleanups
    result = func(*args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/commit.py", line 447, in _commit
    self.rev_id = self.builder.commit(self.message)
  File "/home/abentley/hacking/bzr/bzrlib/vf_repository.py", line 204, in commit
    testament = Testament(rev, self.revision_tree())
  File "/home/abentley/hacking/bzr/bzrlib/vf_repository.py", line 230, in revision_tree
    self._new_revision_id)
  File "/home/abentley/hacking/bzr/bzrlib/decorators.py", line 155, in read_locked
    result = unbound(self, *args, **kwargs)
  File "/home/abentley/hacking/bzr/bzrlib/remote.py", line 1923, in get_inventory
 ...