May provide strings as attributes rather than unicode
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
lazr.restfulclient |
Triaged
|
Low
|
Unassigned |
Bug Description
Hi,
While trying to land the launchpadlib update in to Launchpad itself, I ran in to test failures
with the latest release.
Confused I went to try and reproduce in lp:launchpadlib.
I ran python bootstrap.py && ./bin/buildout && ./bin/test and found that test_no_
was failing, as it was expecting the "beta" webservice, when 1.0 is default. This is bug 488448.
I didn't see the failures I was seeing when using in launchpad, and so dicsovered
that ./bin/test doesn't run any of the doctests, and I think this may mean that the tests
haven't been getting exercised.
Writing a small test_docs.py to load the doctests I was able to run them.
The failure I got, which was the same as when trying to land the upgrade was:
File "/home/
Failed example:
me.name
Expected:
u'salgado'
Got:
'salgado'
which is what was failing when I tried to upgrade launchpad's copy.
This one is caused by the
332 representation = simplejson.
in lazr.restfulcli
simplejson.
Thanks,
James
Ah, I get it now, these doctests aren't supposed to be run outside of the Launchpad test suite.
Still, there are a couple of real bugs here, one of which is caught by the lazr.restfulclient
testsuite, but it seems that if run with an older simplejson or something it doesn't trigger
the problem. The other can be caught with a test there too.
Thanks,
James