Comment 1 for bug 590559

Revision history for this message
Gary Poster (gary) wrote :

"making it easy to scan for network ops": you mean, in the codebase? That would be a coding convention which would be easily forgotten and ignored on one hand, and on the other hand could be replaced with other coding conventions that didn't require alternat APIs (e.g., remote_branch.createMergeProposal...).

"familiarity to Twisted programmers": if it doesn't return a Deferred, this seems of very minimal gain. I'd personally prefer an approach that had an alternate root object that kept the same API but returned Deferreds.

- A given root object only supports one approach, so it is less accident-prone.
- Programmers can learn a single API, and either use standard blocking calls or Deferreds.

Of course, that may be a pipe dream, for one reason or another. Or perhaps that's what James is experimenting with?

I'm very inclined to call this a Won't Fix, but will call it a Triaged: Low for now in case you convince me otherwise.