lazr.restfulclient using lowercase get in HTTP request

Bug #1401544 reported by Alexander List on 2014-12-11
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lazr.restfulclient
Undecided
Unassigned
lazr.restfulclient (Ubuntu)
Undecided
Unassigned
Lucid
High
Colin Watson
Precise
High
Colin Watson

Bug Description

http://tools.ietf.org/html/rfc2616#section-5.1.1 specifies that methods in HTTP are case sensitive.

Some server implementations may be graceful about this (e.g. apache), others may enforce the specification.

All the other methods are written in uppercase, so I suggest to bring GET in line as well.

Test case: Install python-launchpadlib, then run this at a Python prompt:

>>> import httplib2
>>> httplib2.debuglevel = 1
>>> from launchpadlib.launchpad import Launchpad
>>> lp = Launchpad.login_anonymously("test", "production")
>>> lp.distributions["ubuntu"].getSeries(name_or_version="vivid")

If this bug is present, then the debug output from the last statement will include a line starting with "send: 'get /1.0/ubuntu?ws.op=getSeries"; the fix corrects the GET to be capitalised.

Colin Watson (cjwatson) wrote :

This was fixed by http://bazaar.launchpad.net/~lazr-developers/lazr.restfulclient/trunk/revision/121, but that needs to be backported to lucid and precise for production.

Changed in lazr.restfulclient:
status: New → Fix Released
Changed in lazr.restfulclient (Ubuntu):
status: New → Fix Released
Colin Watson (cjwatson) on 2014-12-11
description: updated
Changed in lazr.restfulclient (Ubuntu Lucid):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Colin Watson (cjwatson)
Changed in lazr.restfulclient (Ubuntu Precise):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Colin Watson (cjwatson)
description: updated

Hello Alexander, or anyone else affected,

Accepted lazr.restfulclient into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lazr.restfulclient/0.12.0-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in lazr.restfulclient (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in lazr.restfulclient (Ubuntu Lucid):
status: In Progress → Fix Committed
Steve Langasek (vorlon) wrote :

Hello Alexander, or anyone else affected,

Accepted lazr.restfulclient into lucid-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/lazr.restfulclient/0.9.11-1ubuntu1.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

James Troup (elmo) wrote :

I can confirm 0.12.0-1ubuntu1.2 fixed the problem for us.

tags: added: verification-done
removed: verification-needed
Colin Watson (cjwatson) wrote :

I checked lucid as well, looks sensible.

The verification of the Stable Release Update for lazr.restfulclient has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lazr.restfulclient - 0.12.0-1ubuntu1.2

---------------
lazr.restfulclient (0.12.0-1ubuntu1.2) precise; urgency=medium

  * Always uppercase HTTP methods to match httplib2 expectations
    (LP: #1401544).
 -- Colin Watson <email address hidden> Thu, 11 Dec 2014 16:44:14 +0000

Changed in lazr.restfulclient (Ubuntu Precise):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lazr.restfulclient - 0.9.11-1ubuntu1.4

---------------
lazr.restfulclient (0.9.11-1ubuntu1.4) lucid; urgency=medium

  * Always uppercase HTTP methods to match httplib2 expectations
    (LP: #1401544).
 -- Colin Watson <email address hidden> Thu, 11 Dec 2014 16:30:02 +0000

Changed in lazr.restfulclient (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers