batching collections containing basic python types

[Edwin Grubbs]

Launchpad sometimes wraps a storm result set with a DecoratedResultSet object, so that an efficient query can be used for batching that only selects the rows needed, but each row may be transformed into a dictionary. Though lazr.restful has no problems JSON encoding a list of dictionaries, the lazr.restful code that provides batching functionality expects each item to have an adapter to an IEntry, which the export_as_webservice_entry() decorator normally enables.

lazr.restful._operation.ResourceOperation.should_batch() turns off batching for lists of dictionaries. When another collection is used that should_batch() says yes to, lazr.restful._resource.BatchingResourceMixin.batch() tries to instantiate an EntryResource object, which cannot handle object that can't be adapted to an IEntry. In Launchpad, batch() will fail before it instantiates an EntryResource, since it calls checkPermission() on the dict, and checkPermission() causes an exception when it tries to put the dict in a weakref. Perhaps, canAccess() should be used instead of checkPermission().

[Gary Poster (gary)]

Edwin, is this affecting code now, or is there a known workaround?