Don't call len() when generating URLs unless absolutely necessary
Bug #620444 reported by
Leonard Richardson
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
lazr.batchnavigator |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
We avoid calling len() within Batch, since len() can be expensive, but we call it all over the place in BatchNavigator. We can get rid of len() for everything except the URL of the last batch, and the distinction between singular and plural.
Related branches
lp:~leonardr/lazr.batchnavigator/build-url-without-length
- Guilherme Salgado (community): Approve (code)
-
Diff: 196 lines (+63/-16)4 files modifiedsrc/lazr/batchnavigator/NEWS.txt (+3/-1)
src/lazr/batchnavigator/README.txt (+58/-13)
src/lazr/batchnavigator/_batchnavigator.py (+1/-1)
src/lazr/batchnavigator/z3batching/batch.py (+1/-1)
Changed in lazr.batchnavigator: | |
status: | New → Fix Released |
To post a comment you must log in.