charm should have options to rotate docker registry log file

[Thomas Cuthbert]

the registry log file can grow quite large and requires manual truncation. The charm should have options to control rotating the logs.

-rw-r----- 1 root root 3.3G Sep 19 01:48 5bfe5f9be6d1819f245adf26598874a68093390764456c84eb870f201760658b-json.log

Using something like https://docs.docker.com/config/containers/logging/json-file/

[Haw Loeung (hloeung)]

This has bitten us elsewhere as well. Any chance this could be bumped to something other than Wishlist?

[Haw Loeung (hloeung)]

Quick search shows there's an option to keep the size constant and rotate out keeping N copies:

daemon.json:

{
  "log-driver": "json-file",
  "log-opts": {"max-size": "10m", "max-file": "3"}
}

Or running dockerd with '--log-opt max-size=10m --log-opt max-file=3'

[Haw Loeung (hloeung)]

Obviously, we want to keep more that 30m worth. Also, FWIW, the path of these logs are:

| /var/lib/docker/containers/.../

[Tim Van Steenburgh (tvansteenburgh)]

PR up for review/feedback: https://github.com/juju-solutions/layer-docker/pull/140/

Still needs tests.

[Tim Van Steenburgh (tvansteenburgh)]

Haw,

> Or running dockerd with '--log-opt max-size=10m --log-opt max-file=3'

FYI, you can do this today with:

juju config docker-registry docker-opts="--log-opt max-size=10m --log-opt max-file=3"

[Tim Van Steenburgh (tvansteenburgh)]

https://github.com/juju-solutions/layer-docker/pull/141
https://github.com/CanonicalLtd/docker-registry-charm/pull/40

These have been tested and are ready for review now.

[Kevin W Monroe (kwmonroe)]

Both PRs from comment 6 are now merged in their master branches.

[George Kraft (cynerva)]

This didn't actually go out with 1.17. I've set milestone to 1.18+ck1 and we're working to include docker-registry in the release this time.

Cherry-pick to stable: https://github.com/charmed-kubernetes/docker-registry-charm/commit/b90c1fed6bdc4762de4fabefa37c4e7bcb396904