docker registry charm ignores juju-http-proxy and juju-https-proxy

[Calvin Hartwell]

Hi all,

The docker registry charm ignores the juju-http-proxy and juju-https-proxy variables which should now be used for handling proxy. The charm specific http-proxy/https-proxy are required instead.

The charm specific options should be given the default values of the the juju-http-proxy/https-proxy and the http-proxy/https-proxy should be used to override the default values if required.

Feel free to ask questions.

[Kevin W Monroe (kwmonroe)]

The http/s-proxy config options come into the docker-registry charm because of the inclusion of layer:docker:

https://github.com/CanonicalLtd/docker-registry-charm/blob/master/layer.yaml#L7

See the config opts defined in that layer here(ish):

https://github.com/juju-solutions/layer-docker/blob/master/config.yaml#L68

Managing these option with their corresponding juju- model config opts should be handled by that project.

[Joseph Borg (joeborg)]

Won't fix in layer-docker as it's been replaced.

[Joseph Borg (joeborg)]

Fixed by Pjds in charm-containerd and charm-dockerd.

[Joseph Borg (joeborg)]

s/charm-dockerd/charm-docker/

[George Kraft (cynerva)]

This was marked as "Won't Fix" following comments in https://github.com/juju-solutions/layer-docker/pull/138. We decided to stop maintaining layer-docker because the CDK charms no longer use it.

Looks like that was the wrong call. We do still use it, in the docker-registry charm.

Based on that, I'm re-opening this against layer-docker (where the fix will likely occur) and charm-docker-registry (where the fix will need to be released).

[George Kraft (cynerva)]

PR: https://github.com/juju-solutions/layer-docker/pull/139

[George Kraft (cynerva)]

Removed charm-containerd and charm-docker from this issue since they were covered in https://bugs.launchpad.net/charm-kubernetes-worker/+bug/1831712.

[George Kraft (cynerva)]

Fix is available in the edge channel with cs:~containers/docker-registry-151