lava website should allow manipulating jobs from CI

[Riku Voipio]

Currently jobs from jenkins are submitted with the user "ciadmin". For example:

http://validation.linaro.org/lava-server/dashboard/streams/private/team/linaro/pre-built-vexpress64/bundles/70b8ac7a3902390b13f99239f4159fa5a9920ad2/

Currently manipulating such jobs (resubmit, abort) is not possible. It would be better if other users could stop/resubmit jobs as needed.

[Dave Pigott (dpigott)]

Hi Arthur - can you get this merged? If you need help, let me know.

[Arthur She (arthur-she)]

Push the patch into https://staging.review.linaro.org/#/c/126/

[Arthur She (arthur-she)]

Antonio suggest that use a permission to control the job manipulating right instead of hard code group name in the source code.
There's a permission "lava_scheduler_app | test job | Can change test job" seems suitable for that.

[Antonio Terceiro (terceiro)]

On Fri, Oct 04, 2013 at 05:37:02AM -0000, Arthur She wrote:
> There's a permission "lava_scheduler_app | test job | Can change test
> job" seems suitable for that.

Not sure about this - changing a job is not what we want. I think we
want a new permission called "can resubmit jobs" or something like it.

--
Antonio Terceiro
Software Engineer - Linaro
http://www.linaro.org

[Arthur She (arthur-she)]

It's not only resubmit but also cancel/abort the jobs, so I thought "Can change test job" might be suitable.
Or a new permission called "Can manipulate test jobs" ?

[Arthur She (arthur-she)]

 - Add a new permission "manipulate_testjob" in class TestJob
   (lava_scheduler_app | test job | Can manipulate test jobs)
 - If user has "manipulate_testjob" permission, user can cancel/re-submit
   test jobs no matter who's the submitter.

fix on staging git https://staging.review.linaro.org/#/c/172/

[Fathi Boudra (fboudra)]

Commented on the proposed patch:
Could you change the term used? "manipulate" doesn't tell you what the permission is about.
I'll suggest to use:
manipulate_testjob -> cancel_resubmit_testjob
"Can manipulate test jobs" -> "Can cancel or resubmit test jobs"

[Arthur She (arthur-she)]

cancel_resubmit_testjob will be better..
Change manipulate_testjob -> cancel_resubmit_testjob
https://staging.review.linaro.org/#/c/174/

[Arthur She (arthur-she)]

modify the previous commit ( https://staging.review.linaro.org/#/c/172/) and abandon the new one (https://staging.review.linaro.org/#/c/174/)

[Arthur She (arthur-she)]

Due to command "lava-server manage syncdb --all" will cause db migration
fail and it need to modify lava-deployment-tool. Change to data
migration method to add the new permission cancel_resubmit_testjob.
Anyone who has this permission can cancel / resubmit test jobs.

https://staging.review.linaro.org/#/c/321/

[Arthur She (arthur-she)]

The patches had been merged in revision #9cd85a6477