split_multi_job makes assumptions about the job JSON that are not enforced by the schema
Bug #1224260 reported by
Michael Hudson-Doyle
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
LAVA Scheduler (deprecated) |
Fix Released
|
High
|
Senthil Kumaran S |
Bug Description
In particular:
1) an element of the device_groups list is assumed to have tags
2) the job is assumed to have a logging_level key
(there may be other bits too).
The consequence of this is that submitting a job that fails either of these assumptions just 500s, rather than getting an informative message. Either (a) the scheme needs to be tighter or (b) split_multi_job needs to be more forgiving (and (b) is the correct choice here :-))
Related branches
lp:~stylesen/lava-dispatcher/fix-bug-1224260
- Neil Williams: Approve
-
Diff: 14 lines (+3/-1)1 file modifiedlava_dispatcher/actions/lava_test_shell.py (+3/-1)
lp:~stylesen/lava-scheduler/fix-bug-1224260
- Neil Williams: Approve
-
Diff: 28 lines (+9/-3)1 file modifiedlava_scheduler_app/utils.py (+9/-3)
description: | updated |
Changed in lava-scheduler: | |
assignee: | nobody → Senthil Kumaran S (stylesen) |
importance: | Undecided → Medium |
importance: | Medium → High |
status: | New → In Progress |
Changed in lava-scheduler: | |
status: | In Progress → Fix Committed |
Changed in lava-scheduler: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.